- Apr 14, 2017
-
-
Nao YONASHIRO authored
PR-URL: https://github.com/nodejs/node/pull/12354 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Josh Gavant authored
* Removes "experimental" warning. Fixes: https://github.com/nodejs/node/issues/11770 PR-URL: https://github.com/nodejs/node/pull/12352 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Anna Henningsen authored
Missed in ca786c37. This does not actually affect the outcome because returning `nullptr` or `this` from a constructor has the same effect. PR-URL: https://github.com/nodejs/node/pull/12318 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: https://github.com/nodejs/node/pull/12330 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
- Apr 13, 2017
-
-
Tarun Batra authored
Set the expected outcome of `util.format('%%')` to be `%%` instead of `%`. PR-URL: https://github.com/nodejs/node/pull/12374 Fixes: https://github.com/nodejs/node/issues/12362 Reviewed-By:Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Sam Roberts authored
bootstrap_node.js was directly parsing process.execArgv to see if internals should be exposed, even though the argv was already parsed by node. This is unusual and unnecessary, change it to set the option value from the parser onto the config binding. PR-URL: https://github.com/nodejs/node/pull/12245 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Sam Roberts authored
A few of the CLI option values exposed as properties on the process object were missing a comment, fix this. PR-URL: https://github.com/nodejs/node/pull/12245 Reviewed-By:
-
Michaël Zasso authored
Enables the requireTwo option of our custom rule. PR-URL: https://github.com/nodejs/node/pull/12270 Reviewed-By:
-
Michaël Zasso authored
This adds RegExp or error constructor arguments to the remaining places where it is missing in preparation for the commit that will enforce the presence of at least two arguments. PR-URL: https://github.com/nodejs/node/pull/12270 Reviewed-By:
-
Shubheksha Jalan authored
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: https://github.com/nodejs/node/pull/12312 Fixes: https://github.com/nodejs/node/issues/12299 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
Refs: https://github.com/nodejs/node/pull/12170 PR-URL: https://github.com/nodejs/node/pull/12317 Reviewed-By:
-
Rich Trott authored
common.fail() was added to paste over issues with assert.fail() function signature. assert.fail() has been updated to accept a single argument so common.fail() is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/12293 Reviewed-By:
-
Rich Trott authored
assert.fail() has been updated to accept a single argument so that is no longer an error. Remove lint rule that checks for assert.fail() with a single argument. PR-URL: https://github.com/nodejs/node/pull/12293 Reviewed-By:
-
Rich Trott authored
assert.fail() has two possible function signatures, both of which are not intuitive. It virtually guarantees that people who try to use assert.fail() without carefully reading the docs will end up using it incorrectly. This change maintains backwards compatibility with the two valid uses (arguments 1 2 and 4 supplied but argument 3 falsy, and argument 3 supplied but arguments 1 2 and 4 all falsy) but also adds the far more intuitive first-argument-only and first-two-arguments-only possibilities. assert.fail('boom'); // AssertionError: boom assert.fail('a', 'b'); // AssertionError: 'a' != 'b' PR-URL: https://github.com/nodejs/node/pull/12293 Reviewed-By: -
Rich Trott authored
Replace custom lint rule for `assert.fail()` function signature errors with a restricted-syntax rule. PR-URL: https://github.com/nodejs/node/pull/12287 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Michael Dawson authored
Add basic tests for handle scopes as code coverage reports that we are not covering these with the existing tests. PR-URL: https://github.com/nodejs/node/pull/12327 Reviewed-By:
-
Michael Dawson authored
We've discussed this with the Power team within IBM and have agreement that we should drop Power Linux BE for Node version 8 as customers will be using Power Linux LE when using Node.js going forward. PR-URL: https://github.com/nodejs/node/pull/12309 Reviewed-By:
George Adams <george.adams@uk.ibm.com> Reviewed-By:
Jaideep Bajwa <bjaideep@ca.ibm.com>
-
Daijiro Wachi authored
Fixes: https://github.com/nodejs/node/issues/11485 PR-URL: https://github.com/nodejs/node/pull/12331 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12223 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12223 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12223 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/12223 Reviewed-By:
-
- Apr 12, 2017
-
-
Daniel Bevenius authored
This commit attempts to address one of the TODOs in https://github.com/nodejs/node/issues/4641 regarding making the AtExit callback's per environment, instead of the current global. bnoordhuis provided a few options for solving this, and one was to use a thread-local which is what this commit attempts to do. PR-URL: https://github.com/nodejs/node/pull/9163 Reviewed-By:
-
Daniel Bevenius authored
Currently, the following warning will be reported when configuring without-ssl: ../src/node.cc:3653:8: warning: unused variable 'use_bundled_ca' [-Wunused-variable] bool use_bundled_ca = false; ^ ../src/node.cc:3654:8: warning: unused variable 'use_openssl_ca' [-Wunused-variable] bool use_openssl_ca = false; ^ I missed this when working on commit 8a7db9d4 ("src: add --use-bundled-ca --use-openssl-ca check"). Refs: https://github.com/nodejs/node/pull/12087 PR-URL: https://github.com/nodejs/node/pull/12302 Reviewed-By: -
Daniel Bevenius authored
When configuring and building --without-ssl the following warning is reported: ../src/node_debug_options.cc:12:11: warning: unused variable 'default_inspector_port' [-Wunused-const-variable] const int default_inspector_port = 9229; The commit adds a HAVE_INSPECTOR guard to this constant. PR-URL: https://github.com/nodejs/node/pull/12303 Reviewed-By:
-
Ali Ijaz Sheikh authored
`node debug` is now an alias of `node inspect`. This is intended to be a minimal change – it does not get rid of the the debugger code. That can be done in a follow-on. PR-URL: https://github.com/nodejs/node/pull/11441 Reviewed-By:
joshgav - Josh Gavant <josh.gavant@outlook.com> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com>
-
Ali Ijaz Sheikh authored
Node 8.x no longer has --debug-brk. Ref: https://github.com/nodejs/node-inspect/pull/43 PR-URL: https://github.com/nodejs/node/pull/11441 Reviewed-By:
-
Vse Mozhet Byt authored
Unify spaces, quotes, and semicolons. Update output examples. PR-URL: https://github.com/nodejs/node/pull/12296 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Eugene Ostroukhov authored
PR-URL: https://github.com/nodejs/node/pull/12272 Reviewed-By:
-
Italo A. Casas authored
Notable changes: * util: console is now closer to what is supported in all major browsers (Roman Reiss) [#10308](https://github.com/nodejs/node/pull/10308) PR-URL: https://github.com/nodejs/node/pull/12319
-
- Apr 11, 2017
-
-
Ben Noordhuis authored
`napi_env__` was declared as a struct in one place and a class in another. PR-URL: https://github.com/nodejs/node/pull/12333 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
João Reis authored
Increase the number of shards to divide v8_base into. This increases the number of calls to cl.exe but decreases the number of files compiled each time. Fixes: https://github.com/nodejs/v8/issues/4 PR-URL: https://github.com/nodejs/node/pull/12184 Reviewed-By:
-
João Reis authored
MSBuild invokes cl.exe with /MP (set in common.gypi), making it compile sources in parallel using a number of internal processes equal to the number of effective processors. MSBuild /m uses a similar mechanism, so the number of compiler processes can grow to the number of effective processors squared. This limits MSBuild to 2 processes, to still use some parallelization while requiring less memory. Cl.exe is still invoked with /MP, thus the maximum number of processes is limited to twice the number of effective processors. PR-URL: https://github.com/nodejs/node/pull/12184 Reviewed-By:
-
Karl Cheng authored
Fixes parallel/test-buffer-bindingobj-no-zerofill to properly check that buffers created with `Buffer.allocUnsafe()` are not zero-filled. The test introduced in #11706 passes even if the buffer has been zero-filled and fails if none of the buffer values are zero. Refs: https://github.com/nodejs/node/pull/11706 PR-URL: https://github.com/nodejs/node/pull/12290 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/12294 Fixes: https://github.com/nodejs/node/issues/12291 Reviewed-By:
-
Roman Reiss authored
This is to override GitHub's default behaviour that links to the image's source file, which isn't very helpful in our case. PR-URL: https://github.com/nodejs/node/pull/12307 Reviewed-By:
-
Rich Trott authored
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners. PR-URL: https://github.com/nodejs/node/pull/12275 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/12059 Reviewed-By:
-
Joyee Cheung authored
Sort phony rules and place them one per line for the ease of updating and backporting PR-URL: https://github.com/nodejs/node/pull/12059 Reviewed-By:
-
taylor.woll authored
Based on the async methods we had in abi-stable-node before the napi feature landed in node/master. Changed this set of APIs to handle error cases and removed a lot of the extra methods we had for setting all the pieces of napi_work opting instead to pass all of those as arguments to napi_create_async_work as none of those parameters are optional except for the complete callback, anyway. Renamed the napi_work struct to napi_async_work and replace the struct itself with a class which can better encapsulate the object lifetime and uv_work_t that we're trying to wrap anyway. Added a napi_async_callback type for the async helper callbacks instead of taking raw function pointers and make this callback take a napi_env parameter as well as the void* data it was already taking. Call the complete handler for the async work item with a napi_status code translated from the uvlib error code. The execute callback is required for napi_create_async_work, though complete callback is still optional. Also added some async unit tests for addons-napi based on the addons/async_hello_world test. PR-URL: https://github.com/nodejs/node/pull/12250 Reviewed-By:
Hitesh Kanwathirtha <hiteshk@microsoft.com>
-
