- Oct 14, 2017
-
-
Anna Henningsen authored
This should help clarify what kind of resource a `StreamWrap` represents. PR-URL: https://github.com/nodejs/node/pull/16157 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
shaohui.liu2000@gmail.com authored
PR-URL: https://github.com/nodejs/node/pull/15816 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
shaohui.liu2000@gmail.com authored
PR-URL: https://github.com/nodejs/node/pull/15816 Reviewed-By:
-
Mabry Cervin authored
PR-URL: https://github.com/nodejs/node/pull/15912 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Eric Freiberg authored
PR-URL: https://github.com/nodejs/node/pull/15922 Reviewed-By:
-
Kat Rosario authored
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: https://github.com/nodejs/node/pull/15930 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Chad Zezula authored
Change all assert.strictEqual() to have actual value 1st and expected value 2nd. PR-URL: https://github.com/nodejs/node/pull/16008 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Rich Trott authored
As discussed in TSC email, I contacted 8 Collaborators whose last activity appears to be quite some time ago to suggest that they be moved to emeritus status until such a time as they will be active again. There were no objections from the 8 Collaborators or the TSC. PR-URL: https://github.com/nodejs/node/pull/16173 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Matthew Meyer authored
Updated parallel/test-require-resolve.js to use the fixtures module. PR-URL: https://github.com/nodejs/node/pull/15984 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Move test-esm-addons to test/addons/hello-world-esm. Test should now work properly on CI machines where `addons` are not always built at the expected relative path from the es-modules tests. Test should now work in Debug builds. PR-URL: https://github.com/nodejs/node/pull/16174 Fixes: https://github.com/nodejs/node/issues/16155 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
- Oct 13, 2017
-
-
Gibson Fahnestock authored
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: https://github.com/nodejs/node/pull/16053#issuecomment-334868621 PR-URL: https://github.com/nodejs/node/pull/16054 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
szhang351 authored
PR-URL: https://github.com/nodejs/node/pull/15841/ Reviewed-By:
-
Dolapo Toki authored
PR-URL: https://github.com/nodejs/node/pull/15836 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Gene Wu authored
PR-URL: https://github.com/nodejs/node/pull/15822 Reviewed-By:
-
Christian Murphy authored
PR-URL: https://github.com/nodejs/node/pull/15817 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
-
Cristian Peñarrieta authored
PR-URL: https://github.com/nodejs/node/pull/15833 Reviewed-By:
-
Gabriel Schulhof authored
test_constructor_name.c should use NODE_GYP_MODULE_NAME. PR-URL: https://github.com/nodejs/node/pull/16146 Reviewed-By:
-
Tom Boutell authored
PR-URL: https://github.com/nodejs/node/pull/15805 Reviewed-By:
-
Nicolas Chaulet authored
In test/parallel/test-process-redirect-warning.js replace usage of common.fixture by common.fixturesDir PR-URL: https://github.com/nodejs/node/pull/15917 Reviewed-By:
-
Raj Parekh authored
removed string literal argument to function call strictEqual so that default error message is printed PR-URL: https://github.com/nodejs/node/pull/16011 Reviewed-By:
-
kysnm authored
PR-URL: https://github.com/nodejs/node/pull/15878 Reviewed-By:
-
Bob Clewell authored
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: https://github.com/nodejs/node/pull/15886 Reviewed-By:
-
Jem Bezooyen authored
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory. Make use of the `fixturesDir` value from module rather than value from common. - Replace `common.fixtures` with `fixtures.fixturesDir` PR-URL: https://github.com/nodejs/node/pull/15815 Reviewed-By:
-
Alberto Lopez de Lara authored
PR-URL: https://github.com/nodejs/node/pull/15870 Reviewed-By:
-
Suresh Srinivas authored
PR-URL: https://github.com/nodejs/node/pull/15869 Reviewed-By:
-
Rich Trott authored
A benchmark for module loading creates a temporary directory in the benchmark directory. Re-use the test common module to put the tmp directory in test instead. This was causing intermittent test failures because run.js (invoked by benchmark tests, mulitple of which could be running at once) throws if a subdirectory of benchmark disappears at just the wrong time. There are other possible solutions than repurposing the `test/common` module but two arguments for doing it this way are: * There is already another benchmark file that does this (`http_server_for_chunky_client.js`) so the dependency already exists in the benchmarks. * This also eliminates a re-implementation of rimraf in the benchmark code. PR-URL: https://github.com/nodejs/node/pull/16144 Reviewed-By:
-
Kai Cataldo authored
PR-URL: https://github.com/nodejs/node/pull/15850 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
tobyfarley authored
PR-URL: https://github.com/nodejs/node/pull/15905 Reviewed-By:
-
r1cebank authored
PR-URL: https://github.com/nodejs/node/pull/15990 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
-
Ethan Arrowood authored
Added parallel test benchmark for es PR-URL: https://github.com/nodejs/node/pull/16076 Reviewed-By:
-
Rich Trott authored
`common.refreshTmpDir()` is a function. Add parentheses to make that explicit. Also copy edit the descriptive sentence. PR-URL: https://github.com/nodejs/node/pull/16168 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Donovan Buck authored
PR-URL: https://github.com/nodejs/node/pull/15986 Reviewed-By:
-
jpaulptr authored
PR-URL: https://github.com/nodejs/node/pull/15941 Reviewed-By:
-
Kat Rosario authored
Replace use of fixturesDir with fixtures.readSync and fixtures.path. PR-URL: https://github.com/nodejs/node/pull/15856 Reviewed-By:
-
Lewis Zhang authored
PR-URL: https://github.com/nodejs/node/pull/16165 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
F. Hinkelmann authored
PR-URL: https://github.com/nodejs/node/pull/16069 Reviewed-By:
-
Ethan Brown authored
PR-URL: https://github.com/nodejs/node/pull/16030 Reviewed-By:
-
Rich Trott authored
Supply `type=asc` option in test-benchmark-http to reduce runs in all benchmark files to one combination of options. PR-URL: https://github.com/nodejs/node/pull/16137 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
-
Rich Trott authored
Run only one benchmark for each benchmark file tested by test-benchmark-misc.js. PR-URL: https://github.com/nodejs/node/pull/16120 Reviewed-By:
-
- Oct 12, 2017
-
-
ekulnivek authored
PR-URL: https://github.com/nodejs/node/pull/15839 Reviewed-By:
-
