Commits · 00687fb5044d9ab3361e445b7bf8949bf99994e2 · github.com / v8-riscv / node

Jan 25, 2018

deps: V8: backport 76c3ac5 from upstream · 00687fb5

Ali Ijaz Sheikh authored Jan 22, 2018

This fixes a bug in the CPU profiler where some ticks were attributed
to the wrong file.

Original commit message:
  [cpu-profiler] Fix script name when recording inlining info

  Use the script name from the shared function info to create an
  inline entry. Otherwise functions are attributed to the wrong file
  in the CpuProfileNode.

  See https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs/issues/89

  Bug: v8:7203, v8:7241
  Change-Id: I8ea31943741770e6611275a9c93375922b934547
  Reviewed-on: https://chromium-review.googlesource.com/848093


Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
  Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#50339}

Refs: https://github.com/v8/v8/commit/76c3ac58b00e08e3e2fecc3f7169bd64d91c8f75
PR-URL: https://github.com/nodejs/node/pull/18298


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

00687fb5

src: use uv_hrtime as tracing timestamp · 98d9540d

Ali Ijaz Sheikh authored Jan 16, 2018

Override the V8 TracingController to provide uv_hrtime based
timestamps. This allows tracing timestamps to be comparable with
process.hrtime timestamps.

Fixes: https://github.com/nodejs/node/issues/17349
PR-URL: https://github.com/nodejs/node/pull/18196


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

98d9540d

deps: cherry-pick c3bb73f from upstream V8 · 51054dac

Ali Ijaz Sheikh authored Jan 16, 2018

Original commit message:

    [tracing] implement TRACE_EVENT_ADD_WITH_TIMESTAMP

    Bug:
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Icb3cf7b7f96704e1eaa4c5fbf773b94b70cddc85
    Reviewed-on: https://chromium-review.googlesource.com/861302


Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
    Cr-Commit-Position: refs/heads/master@{#50549}

Refs: https://github.com/v8/v8/commit/c3bb73f6b95c280cee3a4d6b03c87fce93d617c7
Refs: https://github.com/nodejs/node/issues/17349
PR-URL: https://github.com/nodejs/node/pull/18196


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

51054dac

deps: cherry-pick 814577e from upstream V8 · 7d7a5492

Ali Ijaz Sheikh authored Jan 16, 2018

Original commit message:

    [tracing] allow embedders to provide own tracing timestamps

    Make it possible for embedders to provide their own tracing timetamps by
    providing an overridable virtual function on V8's tracing controller.

    Bug:
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I727e633cb7f63d4b41c2e427ecca3c9174c90bfe
    Reviewed-on: https://chromium-review.googlesource.com/847690


Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
    Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
    Cr-Commit-Position: refs/heads/master@{#50489}

Refs: https://github.com/v8/v8/commit/814577e3fd097ef772fd6d92a1ad3abd934506e6
Refs: https://github.com/nodejs/node/issues/17349
PR-URL: https://github.com/nodejs/node/pull/18196


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

7d7a5492

Jan 24, 2018

test: use correct size in test-stream-buffer-list · 2313424a

Luigi Pinca authored Jan 18, 2018

The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.

PR-URL: https://github.com/nodejs/node/pull/18239


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

2313424a

stream: remove unreachable code · 80b3acca

Luigi Pinca authored Jan 18, 2018

To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.

PR-URL: https://github.com/nodejs/node/pull/18239


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

80b3acca

assert: stricter ifError · e65a6e81

Ruben Bridgewater authored Jan 23, 2018

This makes `assert.ifError` stricter by only accepting `null` and
`undefined` from now on. Before any truthy value was accepted.

PR-URL: https://github.com/nodejs/node/pull/18247


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

e65a6e81

assert: use destructuring for errors · 8e6e1c9d

Ruben Bridgewater authored Jan 23, 2018

Destructure the necessary Error classes from internal/errors.
This improves the readability of the error creation.

PR-URL: https://github.com/nodejs/node/pull/18247


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8e6e1c9d

assert: wrap original error in ifError · 72bb4445

Ruben Bridgewater authored Jan 19, 2018

It is hard to know where ifError is actually triggered due to the
original error being thrown.
This changes it by wrapping the original error in a AssertionError.
This has the positive effect of also making clear that it is indeed
a assertion function that triggered that error.

The original stack can still be accessed by checking the `actual`
property.

PR-URL: https://github.com/nodejs/node/pull/18247


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

72bb4445

buffer: coerce offset to integer · 7a23fc07

Ruben Bridgewater authored Jan 17, 2018

The offset was formerly coerced to a integer and this reimplements
that.

PR-URL: https://github.com/nodejs/node/pull/18215
Fixes: https://github.com/nodejs/node/issues/18208


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

7a23fc07

tty: refactor to es6 · 373e893e

Ruben Bridgewater authored Jan 17, 2018

PR-URL: https://github.com/nodejs/node/pull/17615


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

373e893e

tty: add getColorDepth function · bb9cedb0

Ruben Bridgewater authored Jan 16, 2018

Right now it is very difficult to determine if a terminal supports
colors or not. This function adds this functionality by detecting
environment variables and checking process.

PR-URL: https://github.com/nodejs/node/pull/17615


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

bb9cedb0

lib: add internal removeColors helper · 19bff313

Ruben Bridgewater authored Dec 11, 2017

Instead of having three times the same RegExp, just use a helper.

PR-URL: https://github.com/nodejs/node/pull/17615


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

19bff313

assert: improve error messages · 2d9e8769

Ruben Bridgewater authored Dec 09, 2017

From now on all error messages produced by `assert` in strict mode
will produce a error diff.

PR-URL: https://github.com/nodejs/node/pull/17615


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

2d9e8769

doc: add missing word in modules.md · cb88f35a

Robert Adamian authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18343


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

cb88f35a

doc: add doc for performance.clearGC() · d8263a06

Antony Tran authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18331


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

d8263a06

doc: document the collaborator nomination process · 62880503

Joyee Cheung authored Jan 20, 2018

PR-URL: https://github.com/nodejs/node/pull/18268
Fixes: https://github.com/nodejs/node/issues/18090
Refs: https://github.com/nodejs/TSC/pull/472


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

62880503

doc: improve the instructions of onboarding PR · 0e7050ec

Joyee Cheung authored Jan 20, 2018

PR-URL: https://github.com/nodejs/node/pull/18268
Fixes: https://github.com/nodejs/node/issues/18090
Refs: https://github.com/nodejs/TSC/pull/472


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

0e7050ec

deps: upgrade libuv to 1.19.1 · a083786c

cjihrig authored Jan 19, 2018

PR-URL: https://github.com/nodejs/node/pull/18260


Reviewed-By: James M Snell <jasnell@gmail.com>

a083786c

test: improve fs error message test · 63f78f5d

Joyee Cheung authored Jan 21, 2018

- Reuse error validators for sync and async tests
- Validate properties of the errors

PR-URL: https://github.com/nodejs/node/pull/18277


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

63f78f5d

fs: use AliasedBuffer for fs_stats_field_array · d09d8782

Joyee Cheung authored Jan 21, 2018

PR-URL: https://github.com/nodejs/node/pull/18276


Reviewed-By: James M Snell <jasnell@gmail.com>

d09d8782

build: make lint-js independent of local node · 13bc53fb

Joyee Cheung authored Jan 21, 2018

PR-URL: https://github.com/nodejs/node/pull/18272


Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

13bc53fb

build: make lint-md independent of local node · be0778b3

Joyee Cheung authored Jan 21, 2018

PR-URL: https://github.com/nodejs/node/pull/18272


Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

be0778b3

doc: split CONTRIBUTING.md · 695ed671

Joyee Cheung authored Jan 20, 2018

PR-URL: https://github.com/nodejs/node/pull/18271
Fixes: https://github.com/nodejs/node/issues/17842


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

695ed671

doc: fix typos in async_hooks · 6a56a0a3

Matthew Turner authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18314


Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

6a56a0a3

src: fix fs.write() externalized string handling · b2b9d11a

Ben Noordhuis authored Jan 23, 2018

* Respect `encoding` argument when the string is externalized.

* Copy the string when the write request can outlive the externalized
  string.

This commit removes `StringBytes::GetExternalParts()` because it is
fundamentally broken.

Fixes: https://github.com/nodejs/node/issues/18146
PR-URL: https://github.com/nodejs/node/pull/18216


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

b2b9d11a

build: define NOMINMAX on windows · 0b1841d8

Ben Noordhuis authored Jan 23, 2018

Build with `-DNOMINMAX` to stop `<windows.h>` from defining macros that
conflict with `std::min()` and `std::max()`.

PR-URL: https://github.com/nodejs/node/pull/18216


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

0b1841d8

doc: add missing URL argument types in fs.md · 91453880

Vse Mozhet Byt authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18309


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

91453880

Jan 23, 2018

doc: remove confusing signature in fs.md · 9870b538

Vse Mozhet Byt authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18310
Fixes: https://github.com/nodejs/node/issues/18305
Refs: https://github.com/nodejs/node/pull/13424


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

9870b538

test: change assert message to default · f5d9169d

ryanmahan authored Jan 19, 2018

assert.strictEqual message argument removed to replace
with default assert message to show the expected vs
actual values

PR-URL: https://github.com/nodejs/node/pull/18259
Refs: https://github.com/nodejs/node/issues/13296


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f5d9169d

benchmark: use destructuring · 6394c8d9

Ruben Bridgewater authored Dec 30, 2017

This applies to all `async_hooks`, `dns`, `cluster`, `domain` and
`module` benchmarks.

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

6394c8d9

benchmark: (dgram) use destructuring · b2966043

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

b2966043

benchmark: (child_process) use destructuring · d49580d8

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d49580d8

benchmark: (buffers) use destructuring · 8e3d7623

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8e3d7623

benchmark: (events) use destructuring · 896397b5

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

896397b5

benchmark: (es) use destructuring · ed91f584

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ed91f584

benchmark: (fs) use destructuring · 7e03ffcc

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7e03ffcc

benchmark: (http) use destructuring · a52878c2

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

a52878c2

benchmark: (misc) use destructuring · fd45187d

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

fd45187d

benchmark: (http2) use destructuring · 50d2554d

Ruben Bridgewater authored Dec 30, 2017

PR-URL: https://github.com/nodejs/node/pull/18250


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

50d2554d