deps: V8: cherry-pick cfe9172
Original commit message:
[wasm] Disallow interpreter move
The MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR macro defines a defaulted move
constructor and move-assignment operator. The {std::unique_ptr} on the
other hand needs the contained type to be complete when instantiating
the move assignment operator. Hence, this fails e.g. on MSVC, see
https://github.com/nodejs/node/pull/30020#issuecomment-544485991.
It turns out that we never actually move the interpreter, so we can
just replace the MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR by
DISALLOW_COPY_AND_ASSIGN.
R=ahaas@chromium.org
Change-Id: Iba7d30243510ed9554be62b0c4c8e6f47f0c3307
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871921
Reviewed-by:
Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64423}
Refs: https://github.com/v8/v8/commit/cfe9172e64795a69112f8247bdcc00954ca9515e
PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
Reviewed-By:
Anna Henningsen <anna@addaleax.net>
Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
parent
d751952c
Please register or sign in to comment