1. May 05, 2023
    • Ralf W. Grosse-Kunstleve's avatar
      9651d3bd
    • Franz Pöschel's avatar
      Introduce recursive_container_traits (#4623) · f7016546
      Franz Pöschel authored
      
      
      * Testing
      
      * Similar fix for std::vector
      
      * Fix infinite recursion check:
      
      1) Apply to is_copy_assignable additionally
      2) Check infinite recursion for map-like types
      
      * style: pre-commit fixes
      
      * Optional commit that demonstrates the limitations of this PR
      
      * Fix positioning of container bindings
      
      The bindings were previously in a block that was only activated if numpy
      was available.
      
      * Suggestions from code review: API side
      
      * Suggestions from code review: Test side
      
      * Suggestions from code review
      
      1) Renaming: is_recursive_container and
         MutuallyRecursiveContainerPair(MV|VM)
      2) Avoid ambiguous specializations of is_recursive_container
      
      * Some little fixes
      
      * Reordering of structs
      
      * Add recursive checks for is_move_constructible
      
      * Static testing for pybind11 type traits
      
      * More precise checking of recursive types
      
      Instead of a trait `is_recursive_container`, use a trait
      `recursive_container_traits` with dependent type
      `recursive_container_traits::type_to_check_recursively`.
      So, instead of just checking if a type is recursive and then trying to
      somehow deal with it, recursively-defined traits such as
      is_move_constructible can now directly ask this trait where the
      recursion should proceed.
      
      * Review suggestions
      
      1. Use std::conditional
      2. Fix typo
      
      * Remove leftover include from test
      
      ---------
      
      Co-authored-by: default avatarpre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
      f7016546
  2. May 03, 2023
  3. May 01, 2023
  4. Apr 29, 2023
  5. Apr 27, 2023
  6. Apr 26, 2023
    • Ralf W. Grosse-Kunstleve's avatar
      Use `std::hash<std::type_index>`, `std::equal_to<std::type_index>` everywhere... · 6de6191a
      Ralf W. Grosse-Kunstleve authored
      Use `std::hash<std::type_index>`, `std::equal_to<std::type_index>` everywhere **except when libc++ is in use** (#4319)
      
      * Try using `std::hash<std::type_index>`, `std::equal_to<std::type_index>` everywhere.
      
      From PR #4316 we know that types in the unnamed namespace in different translation units do not compare equal, as desired.
      
      But do types in named namespaces compare equal, as desired?
      
      * Revert "Try using `std::hash<std::type_index>`, `std::equal_to<std::type_index>` everywhere."
      
      This reverts commit a06949a9265014b3c581396c4f37c45ccc03dea6.
      
      * Use "our own name-based hash and equality functions" for `std::type_index` only under macOS, based on results shown under https://github.com/pybind/pybind11/pull/4316#issuecomment-1305097879
      
      * Patch in PR #4313: Minimal reproducer for clash when binding types defined in the unnamed namespace.
      
      * test_unnamed_namespace_b xfail for clang
      
      * `PYBIND11_INTERNALS_VERSION 5`
      
      * Add a note to docs/classes.rst
      
      * For compatibility with Google-internal testing, test_unnamed_namespace_a & test_unnamed_namespace_b need to work when imported in any order.
      
      * Trying "__GLIBCXX__ or Windows", based on observations from Google-internal testing.
      
      * Try _LIBCPP_VERSION
      
      * Account for libc++ behavior in tests and documentation.
      
      * Adjust expectations for Windows Clang (and make code less redundant).
      
      * Add WindowsClang to ci.yml
      
      Added block transferred from PR #4321
      
      * Add clang-latest to name that appears in the GitHub Actions web view.
      
      * Tweak the note in classes.rst again.
      
      * Add `pip install --upgrade pip`, Show env, cosmetic changes
      
      Already tested under PR #4321
      
      * Add macos_brew_install_llvm to ci.yml
      
      Added block transferred from PR #4324
      
      * `test_cross_module_exception_translator` xfail 'Homebrew Clang'
      
      * Revert back to base version of .github/workflows/ci.yml (the ci.yml changes were merged under #4323 and #4326)
      
      * Fixes for ruff
      
      * Make updated condition in internals.h dependent on ABI version.
      
      * Remove PYBIND11_TEST_OVERRIDE when testing with PYBIND11_INTERNALS_VERSION=10000000
      
      * Selectively exercise cmake `-DPYBIND11_TEST_OVERRIDE`: ubuntu, macos, windows
      
      Extra work added to quick jobs, based on timings below, to not increase the GHA start-to-last-job-finished time.
      
      ```
      Duration
      ^              Number of pytest runs
      ^              ^ Job identifier
      ^              ^ ^
      0:03:48.024227 1 1___3___Clang_3.6___C++11___x64.txt
      0:03:58.992814 1 2___3___Clang_3.7___C++11___x64.txt
      0:04:25.758942 1 1___3.7___Debian___x86____Install.txt
      0:04:50.148276 1 4___3___Clang_7___C++11___x64.txt
      0:04:55.784558 1 13___3___Clang_15___C++20___x64.txt
      0:04:57.048754 1 6___3___Clang_dev___C++11___x64.txt
      0:05:00.485181 1 7___3___Clang_5___C++14___x64.txt
      0:05:03.744964 1 2___3___almalinux8___x64.txt
      0:05:06.222752 1 5___3___Clang_9___C++11___x64.txt
      0:05:11.767022 1 2___3___GCC_7___C++17__x64.txt
      0:05:18.634930 1 2___3.11__deadsnakes____x64.txt
      0:05:22.810995 1 1___3___GCC_7___C++11__x64.txt
      0:05:25.275317 1 12___3___Clang_14___C++20___x64.txt
      0:05:32.058174 1 5___3___GCC_10___C++17__x64.txt
      0:05:39.381351 1 7___3___GCC_12___C++20__x64.txt
      0:05:40.502252 1 8___3___Clang_10___C++17___x64.txt
      0:05:59.344905 1 3___3___Clang_3.9___C++11___x64.txt
      0:06:10.825147 1 6___3___GCC_11___C++20__x64.txt
      0:06:20.655443 1 3___3___almalinux9___x64.txt
      0:06:22.472061 1 3___3___GCC_8___C++14__x64.txt
      0:06:42.647406 1 11___3___Clang_13___C++20___x64.txt
      0:06:53.352720 1 1___3.10___CUDA_11.7___Ubuntu_22.04.txt
      0:07:07.357801 1 2___3.7___MSVC_2019___x86_-DCMAKE_CXX_STANDARD=14.txt
      0:07:09.057603 1 1___3___centos7___x64.txt
      0:07:15.546282 1 1___3.8___MSVC_2019__Debug____x86_-DCMAKE_CXX_STANDARD=17.txt
      0:07:22.566022 1 4___3___GCC_8___C++17__x64.txt
      0:08:13.592674 1 2___3.9___MSVC_2019__Debug____x86_-DCMAKE_CXX_STANDARD=20.txt
      0:08:16.422768 1 9___3___Clang_11___C++20___x64.txt
      0:08:21.168457 1 3___3.8___MSVC_2019___x86_-DCMAKE_CXX_STANDARD=17.txt
      0:08:27.129468 1 10___3___Clang_12___C++20___x64.txt
      0:09:35.045470 1 1___3.10___windows-latest___clang-latest.txt
      0:09:57.361843 1 1___3.9___MSVC_2022_C++20___x64.txt
      0:10:35.187767 1 1___3.6___MSVC_2019___x86.txt
      0:11:14.691200 4 2___3.9___ubuntu-20.04___x64.txt
      0:11:37.701167 1 1_macos-latest___brew_install_llvm.txt
      0:11:38.688299 4 4___3.11___ubuntu-20.04___x64.txt
      0:11:52.720216 1 4___3.9___MSVC_2019___x86_-DCMAKE_CXX_STANDARD=20.txt
      0:13:23.456591 4 6___pypy-3.8___ubuntu-20.04___x64_-DPYBIND11_FINDPYTHON=ON.txt
      0:13:25.863592 2 1___3___ICC_latest___x64.txt
      0:13:32.411758 3 9___3.9___windows-2022___x64.txt
      0:13:45.473377 4 3___3.10___ubuntu-20.04___x64.txt
      0:13:55.366447 4 5___pypy-3.7___ubuntu-20.04___x64.txt
      0:13:57.969502 3 10___3.10___windows-2022___x64.txt
      0:14:19.837475 3 11___3.11___windows-2022___x64.txt
      0:14:33.316770 4 1___3.6___ubuntu-20.04___x64_-DPYBIND11_FINDPYTHON=ON_-DCMA.txt
      0:15:34.449278 4 22___3.6___windows-2019___x64_-DPYBIND11_FINDPYTHON=ON.txt
      0:16:25.189055 2 1___3.9-dbg__deadsnakes____Valgrind___x64.txt
      0:17:20.956667 4 15___3.6___macos-latest___x64.txt
      0:17:27.513891 4 23___3.9___windows-2019___x64.txt
      0:17:58.783286 3 8___3.6___windows-2022___x64.txt
      0:18:25.917828 4 7___pypy-3.9___ubuntu-20.04___x64.txt
      0:19:17.399820 3 13___pypy-3.8___windows-2022___x64.txt
      0:19:45.002122 3 12___pypy-3.7___windows-2022___x64.txt
      0:20:03.201926 4 16___3.9___macos-latest___x64.txt
      0:20:15.415178 4 17___3.10___macos-latest___x64.txt
      0:20:20.263216 4 20___pypy-3.8___macos-latest___x64.txt
      0:20:31.998226 3 1___3___windows-latest___mingw64.txt
      0:20:40.812286 4 18___3.11___macos-latest___x64.txt
      0:22:47.714749 4 19___pypy-3.7___macos-latest___x64.txt
      0:23:04.435859 3 2___3___windows-latest___mingw32.txt
      0:25:48.719597 3 14___pypy-3.9___windows-2022___x64.txt
      0:26:01.211688 4 21___pypy-3.9___macos-latest___x64.txt
      0:28:19.971015 1 1___3___CentOS7__PGI_22.9___x64.txt
      ```
      
      * Update skipif for Python 3.12a7 (the WIP needs to be handled in a separate PR).
      6de6191a
    • Ralf W. Grosse-Kunstleve's avatar
      1. Fully test unstable ABI (#4635) · ff7f5dfc
      Ralf W. Grosse-Kunstleve authored
      2. Selectively exercise cmake `-DPYBIND11_TEST_OVERRIDE`: ubuntu, macos, windows
      
      Extra work added to quick jobs, based on timings below, to not increase the GHA start-to-last-job-finished time.
      
      ```
      Duration
      ^              Number of pytest runs
      ^              ^ Job identifier
      ^              ^ ^
      0:03:48.024227 1 1___3___Clang_3.6___C++11___x64.txt
      0:03:58.992814 1 2___3___Clang_3.7___C++11___x64.txt
      0:04:25.758942 1 1___3.7___Debian___x86____Install.txt
      0:04:50.148276 1 4___3___Clang_7___C++11___x64.txt
      0:04:55.784558 1 13___3___Clang_15___C++20___x64.txt
      0:04:57.048754 1 6___3___Clang_dev___C++11___x64.txt
      0:05:00.485181 1 7___3___Clang_5___C++14___x64.txt
      0:05:03.744964 1 2___3___almalinux8___x64.txt
      0:05:06.222752 1 5___3___Clang_9___C++11___x64.txt
      0:05:11.767022 1 2___3___GCC_7___C++17__x64.txt
      0:05:18.634930 1 2___3.11__deadsnakes____x64.txt
      0:05:22.810995 1 1___3___GCC_7___C++11__x64.txt
      0:05:25.275317 1 12___3___Clang_14___C++20___x64.txt
      0:05:32.058174 1 5___3___GCC_10___C++17__x64.txt
      0:05:39.381351 1 7___3___GCC_12___C++20__x64.txt
      0:05:40.502252 1 8___3___Clang_10___C++17___x64.txt
      0:05:59.344905 1 3___3___Clang_3.9___C++11___x64.txt
      0:06:10.825147 1 6___3___GCC_11___C++20__x64.txt
      0:06:20.655443 1 3___3___almalinux9___x64.txt
      0:06:22.472061 1 3___3___GCC_8___C++14__x64.txt
      0:06:42.647406 1 11___3___Clang_13___C++20___x64.txt
      0:06:53.352720 1 1___3.10___CUDA_11.7___Ubuntu_22.04.txt
      0:07:07.357801 1 2___3.7___MSVC_2019___x86_-DCMAKE_CXX_STANDARD=14.txt
      0:07:09.057603 1 1___3___centos7___x64.txt
      0:07:15.546282 1 1___3.8___MSVC_2019__Debug____x86_-DCMAKE_CXX_STANDARD=17.txt
      0:07:22.566022 1 4___3___GCC_8___C++17__x64.txt
      0:08:13.592674 1 2___3.9___MSVC_2019__Debug____x86_-DCMAKE_CXX_STANDARD=20.txt
      0:08:16.422768 1 9___3___Clang_11___C++20___x64.txt
      0:08:21.168457 1 3___3.8___MSVC_2019___x86_-DCMAKE_CXX_STANDARD=17.txt
      0:08:27.129468 1 10___3___Clang_12___C++20___x64.txt
      0:09:35.045470 1 1___3.10___windows-latest___clang-latest.txt
      0:09:57.361843 1 1___3.9___MSVC_2022_C++20___x64.txt
      0:10:35.187767 1 1___3.6___MSVC_2019___x86.txt
      0:11:14.691200 4 2___3.9___ubuntu-20.04___x64.txt
      0:11:37.701167 1 1_macos-latest___brew_install_llvm.txt
      0:11:38.688299 4 4___3.11___ubuntu-20.04___x64.txt
      0:11:52.720216 1 4___3.9___MSVC_2019___x86_-DCMAKE_CXX_STANDARD=20.txt
      0:13:23.456591 4 6___pypy-3.8___ubuntu-20.04___x64_-DPYBIND11_FINDPYTHON=ON.txt
      0:13:25.863592 2 1___3___ICC_latest___x64.txt
      0:13:32.411758 3 9___3.9___windows-2022___x64.txt
      0:13:45.473377 4 3___3.10___ubuntu-20.04___x64.txt
      0:13:55.366447 4 5___pypy-3.7___ubuntu-20.04___x64.txt
      0:13:57.969502 3 10___3.10___windows-2022___x64.txt
      0:14:19.837475 3 11___3.11___windows-2022___x64.txt
      0:14:33.316770 4 1___3.6___ubuntu-20.04___x64_-DPYBIND11_FINDPYTHON=ON_-DCMA.txt
      0:15:34.449278 4 22___3.6___windows-2019___x64_-DPYBIND11_FINDPYTHON=ON.txt
      0:16:25.189055 2 1___3.9-dbg__deadsnakes____Valgrind___x64.txt
      0:17:20.956667 4 15___3.6___macos-latest___x64.txt
      0:17:27.513891 4 23___3.9___windows-2019___x64.txt
      0:17:58.783286 3 8___3.6___windows-2022___x64.txt
      0:18:25.917828 4 7___pypy-3.9___ubuntu-20.04___x64.txt
      0:19:17.399820 3 13___pypy-3.8___windows-2022___x64.txt
      0:19:45.002122 3 12___pypy-3.7___windows-2022___x64.txt
      0:20:03.201926 4 16___3.9___macos-latest___x64.txt
      0:20:15.415178 4 17___3.10___macos-latest___x64.txt
      0:20:20.263216 4 20___pypy-3.8___macos-latest___x64.txt
      0:20:31.998226 3 1___3___windows-latest___mingw64.txt
      0:20:40.812286 4 18___3.11___macos-latest___x64.txt
      0:22:47.714749 4 19___pypy-3.7___macos-latest___x64.txt
      0:23:04.435859 3 2___3___windows-latest___mingw32.txt
      0:25:48.719597 3 14___pypy-3.9___windows-2022___x64.txt
      0:26:01.211688 4 21___pypy-3.9___macos-latest___x64.txt
      0:28:19.971015 1 1___3___CentOS7__PGI_22.9___x64.txt
      ```
      ff7f5dfc
  7. Apr 24, 2023
  8. Apr 22, 2023
  9. Apr 11, 2023
    • Ralf W. Grosse-Kunstleve's avatar
      Alternative approach to #3807 (#4612) · d930de0b
      Ralf W. Grosse-Kunstleve authored
      * Alternative approach to #3807 that supports an important PyCLIF use case: `Base` not specified in `classh<Derived>` statement, but passing Derived as Base works anyway.
      
      * NOtest_multiple_inheritance_getattr in test_class_sh_void_ptr_capsule.py (quick experiment)
      
      * Revert "NOtest_multiple_inheritance_getattr in test_class_sh_void_ptr_capsule.py (quick experiment)"
      
      This reverts commit e8f0749b895ad941221316a5fa43d873a2b00397.
      
      * Special handling of pybind11 objects to side-step try_as_void_ptr_capsule_get_pointer __getattr__ issues.
      
      * Inspect `internals.registered_types_py` in `type_is_pybind11_class_()`
      
      * Remove debug code in tests subdir.
      
      * Clean up the modified `try_as_void_ptr_capsule_get_pointer()` implementation and new helper functions.
      d930de0b
  10. Apr 09, 2023
  11. Apr 08, 2023
  12. Apr 07, 2023
  13. Apr 03, 2023
  14. Mar 30, 2023
  15. Mar 28, 2023
  16. Mar 27, 2023
  17. Mar 24, 2023
  18. Mar 23, 2023
  19. Mar 17, 2023