- Mar 10, 2020
-
-
Mikhail Maltsev authored
Summary: This patch implements feature test macros for the CDE extension according to the upcoming ACLE specification. The following 2 macros are being added: - __ARM_FEATURE_CDE - defined as '1' when any coprocessor is configured as a CDE coprocessor - __ARM_FEATURE_CDE_COPROC - defined as an 8-bit mask, each bit of the mask corresponds to a coprocessor and is set when the corresponding coprocessor is configured as CDE (and cleared otherwise). The patch also exposes the value of __ARM_FEATURE_CDE_COPROC in the target-independent method TargetInfo::getARMCDECorpocMask, the method will be used in follow-up patches implementing semantic checks of CDE intrinsics (we want to diagnose the cases when CDE intrinsics are used with coprocessors that are not configured as CDE). Reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM Reviewed By: simon_tatham Subscribers: kristof.beyls, danielkiss, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D75843
-
Shiva Chen authored
The patch fixes some typos and introduces ReadFMemBase, ReadFSGNJ32, ReadFSGNJ64, WriteFSGNJ32, WriteFSGNJ64, ReadFMinMax32, ReadFMinMax64, WriteFMinMax32, WriteFMinMax64, so the target CPU with different pipeline model could use them to describe latency. Differential Revision: https://reviews.llvm.org/D75515
-
Jay Foad authored
-
LLVM GN Syncbot authored
-
Jonas Devlieghere authored
This breaks the modules build: http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/ http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ This reverts commit 57c964aa.
-
- Mar 09, 2020
-
-
Kirstóf Umann authored
Nothing exciting to see here! The new interface allows for more fine tuning (register but disable a checker, add custom checker registry functions, etc), that was basically the point. Differential Revision: https://reviews.llvm.org/D67335
-
Muhammad Omair Javaid authored
This patch forces architecture "arm" if underlying os reports core armv7l or armv8l. On linux systems 32 bit sysroot running on 64bit AArch64 hardware reports armv7l or armv8l which is essently arm 32bit mode. This fixes 5 testcases on 32bit arm.
-
Fangrui Song authored
``` createFiles(args) readDefsym readerLinkerScript(*mb) ... readMemory readMemoryAssignment("ORIGIN", "org", "o") // eagerly evaluated target = getTarget(); link(args) writeResult<ELFT>() ... finalizeSections() script->processSymbolAssignments() addSymbol(cmd) // with this patch, evaluated here ``` readMemoryAssignment eagerly evaluates ORIGIN/LENGTH and returns an uint64_t. This patch postpones the evaluation to make * --defsym and symbol assignments * `CONSTANT(COMMONPAGESIZE)` (requires a non-null `lld::elf::target`) work. If the expression somehow requires interaction with memory regions, the circular dependency may cause the expression to evaluate to a strange value. See the new test added to memory-err.s Reviewed By: grimar Differential Revision: https://reviews.llvm.org/D75763 -
Erich Keane authored
The initial implementation only did 'first declaration renaming' when a default version came after. This is insufficient in cases where a default does not exist, so this patch makes sure that we do the renaming in all cases. This renaming is necessary because we emit the first declaration before knowing that it IS a target multiversion function, which would change its name. The second declaration (the one that caused the multiversioning) then needs to make sure that the first one has its name changed to be consistent with the resolver usage.
-
Fangrui Song authored
[lld] Add .clang-tidy to customize readability-identifier-naming.{Member,Parameter,Variable}Case => camelBack lld/.clang-tidy is almost identical to the top-level .clang-tidy, with the aforementioned customization. Reviewed By: ruiu Differential Revision: https://reviews.llvm.org/D75809 -
Fangrui Song authored
https://bugs.llvm.org/show_bug.cgi?id=41910 The feature can disassemble data and the new option name reflects its more generic usage. Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D75816
-
Pavel Labath authored
-
Fangrui Song authored
Reviewed By: grimar Differential Revision: https://reviews.llvm.org/D75798
-
Haojian Wu authored
CHANGELOG: - better ranking for completions - enable dot-to-arrow fix in code completion
-
Alexander Belyaev authored
-
Krzysztof Parzyszek authored
-
Pavel Labath authored
-
Adam Balogh authored
Most of the getter functions (and a reporter function) in `CheckerManager` are constant but not marked as `const`. This prevents functions having only a constant reference to `CheckerManager` using these member functions. This patch fixes this issue. Differential Revision: https://reviews.llvm.org/D75839
-
Thomas Rodgers authored
Summary: These were overlooked on an earlier uglification pass. Differential Revision: https://reviews.llvm.org/D60595
-
Pavel Labath authored
The function always returns a valid object. Let the return type reflect that, and remove some null checks.
-
Haojian Wu authored
Summary: The previous issue is that the item was filtered out by vscode, because the prefix (which contains ".") are not matched against the filterText. This patch works around it by adjusting the item filterText, inspired by https://reviews.llvm.org/D75623. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D75739
-
James Henderson authored
If the minimum_instruction_length of a debug line program is 0, no address advancing via special opcodes, DW_LNS_const_add_pc, and DW_LNS_advance_pc can occur, since the minimum_instruction_length is used in a multiplication. This patch adds a warning reporting when this issue occurs. Reviewed by: probinson Differential Revision: https://reviews.llvm.org/D75189
-
James Henderson authored
The line_range value of a debug line program header is used in divisions related to special opcodes and DW_LNS_const_add_pc opcodes. As such, a value of 0 cannot be used. This change introduces a new warning, if such a situation is identified, and does not perform the relevant calculations. Reviewed by: probinson, aprantl Differential Revision: https://reviews.llvm.org/D43470
-
James Henderson authored
This patch adds a check which reports an unsupported value of the maximum_operations_per_instruction field in a debug line table header. This is reported once per line table, at most, and only if the tablet would otherwise need to use it (i.e. never for tables with version 3 or less, or for tables which don't use DW_LNS_const_add_pc or special opcodes). Unsupported values are currently any apart from 1. Reviewed by: probinson, MaskRay Differential Revision: https://reviews.llvm.org/D74819
-
James Henderson authored
This change is a preparatory change for subsequent commits. Reviewed by: probinson Differential Revision: https://reviews.llvm.org/D75188
-
Pavel Labath authored
Summary: The class has two pairs of functions whose functionalities differ in only how one specifies how much he wants to disasseble. One limits the process by the size of the input memory region. The other based on the total amount of instructions disassembled. They also differ in various features (like error reporting) that were only added to one of the versions. There are various ways in which this could be addressed. This patch does it by introducing a helper struct called "Limit", which is effectively a pair specifying the value that you want to limit, and the actual limit itself. Reviewers: JDevlieghere Subscribers: sdardis, jrtc27, atanasyan, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D75730
-
Alex Cameron authored
Summary: Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39701 This patch is to convert certain characters to their XML escape sequences when generating labels for a DOT graph. I had trouble reproducing the exact issue described on the tracker. I ran `llvm-xray graph` on a log from a test program that included function templates but wasn't able to get the `dot` tool to complain about the `<` and `>` characters. The documentation also suggests that the escape sequences should only be necessary when using HTML string labels which XRay doesn't use (`label=<...>` as opposed to `label="..."`). Perhaps newer versions of Graphviz silently handle this in the case of quoted-string labels. In any case, the generated labels still look correct after this patch and should also fix the reporter's issue. I was a bit unsure how to add a test for this since the existing tests seem to only care about `func-id` rather than giving an actual name. If you could give me a hint on the best way to go about this, that'd be much appreciated! Reviewers: dberris Reviewed By: dberris Subscribers: lebedev.ri, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D69461
-
evgeny authored
Differential revision: https://reviews.llvm.org/D75617
-
Djordje Todorovic authored
Emit call site info only in the case of '-g' + 'O>0' level. Differential Revision: https://reviews.llvm.org/D75175
-
Gabor Marton authored
Summary: This fixes a regression introduced in https://reviews.llvm.org/D74735 Reviewers: NoQ, Szelethus Tags: #clang Differential Revision: https://reviews.llvm.org/D75678
-
Balázs Kéri authored
Summary: ASTImporter makes now difference between variable templates with same name in different translation units if not visible outside. Reviewers: a.sidorin, shafik, a_sidorin Reviewed By: a_sidorin Subscribers: dkrupp, Szelethus, gamesh411, teemperor, martong, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D75732
-
Sjoerd Meijer authored
This reverts commit 2c36c23f. Still problems in the test-suite, which I really thought I had fixed...
-
Sven van Haastregt authored
These should only be defined for signed integer types according to OpenCL v2.0 s6.12.6.
-
KAWASHIMA Takahiro authored
A64FX is an Armv8.2-A CPU used in FUJITSU Supercomputer PRIMEHPC FX1000, PRIMEHPC FX700, and supercomputer Fugaku. https://www.fujitsu.com/global/products/computing/servers/supercomputer/specifications/ Differential Revision: https://reviews.llvm.org/D75594
-
Sjoerd Meijer authored
This includes fixes for: - test-suite: some benchmarks need to be compiled with -fcommon, see D75557. - compiler-rt: one test needed -fcommon, and another a change, see D75520.
-
Balázs Kéri authored
Summary: According to documentations, after an `fclose` call any other stream operations cause undefined behaviour, regardless if the close failed or not. This change adds the check for the opened state before all other (applicable) operations. Reviewers: Szelethus Reviewed By: Szelethus Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, gamesh411, Charusso, martong, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D75614
-
Clement Courbet authored
Summary: This gets rid of duplicated code and diverging behaviour w.r.t. constants. Fixes PR45086. Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75519
-
Nathan James authored
-
Clement Courbet authored
Summary: This gets rid of duplicated code and diverging behaviour w.r.t. constants. Fixes PR45086. Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75519
-
Muhammad Omair Javaid authored
This patch removes skipIf decorator from instruction counting tests. We now use inline intruction in testing inferior to make sure that number of instructions stays fixed. This was tested on aarch64 linux.
-