- Sep 07, 2023
-
-
Craig Topper authored
Hopefully this fixes the expensive checks build.
-
Shilei Tian authored
The function assumes that `__kmp_gtid_get_specific` always returns a valid gtid. That is not always true, because when creating the key for thread-specific data, a destructor is assigned. The dtor will be called at thread exit. However, before the dtor is called, the thread-specific data will be reset to NULL first (https://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_key_create.html): > At thread exit, if a key value has a non-NULL destructor pointer, and the thread > has a non-NULL value associated with that key, the value of the key is set to NULL. This will lead to that `__kmp_gtid_get_specific` returns `KMP_GTID_DNE`. Reviewed By: jdoerfert Differential Revision: https://reviews.llvm.org/D159369
-
Shilei Tian authored
The outlined function is typically invoked by using `__kmp_invoke_microtask`, which is written in asm. D138495 introduces a new interface function for parallel region for OpenMPIRBuilder, where the outlined function is called via the function pointer. For some reason, it works perfectly well on x86 and x86-64 system, but doesn't work on Apple Silicon. The 3rd argument in the callee is always `nullptr`, even if it is not in caller. It appears `x2` always contains `0x0`. This patch adopts the typical method to invoke the function pointer. It works on my M2 Ultra Mac. Fix #63194.
-
Florian Mayer authored
Reviewed By: vitalybuka Differential Revision: https://reviews.llvm.org/D159148
-
zhijian authored
Fixed a compile error on use of deleted function ¡®{anonymous}::MemberData::MemberData(const {anonymous}::MemberData&) Summary: There is compile error on https://lab.llvm.org/buildbot/#/builders/264/builds/1147/steps/5/logs/stdio when commit in https://reviews.llvm.org/D144872
-
- Sep 06, 2023
-
-
Simon Pilgrim authored
Make the DAGCombine helper global so we can more easily reuse it.
-
Simon Pilgrim authored
-
Stefan Gränitz authored
This test still fails since RuntimeDyldChecker needs a few fixes before it works with Thumb. We can remove the XFAIL once the patch in D158280 landed.
-
Ying Yi authored
-
zhijian authored
Summary: if the member file is XCOFF object file and has auxiliary header, the content of the member file need to be aligned at the MAX(maximum alignment of .text , maximum alignment of .data). The "maximum alignment of .text" and "maximum alignment of .data" are two field of auxiliary header of XCOFF object file. Reviewers: James Henderson, Stephen Peckham Differential Revision: https://reviews.llvm.org/D144872
-
Florian Hahn authored
VPWidenRecipe only needs the opcode to widen, all other information (flags, debug loc and operands) is already modeled directly via the recipe. This removes the remaining uses of the underlying instruction from VPWidenRecipe::execute.
-
David Spickett authored
We have docs about how to use lldb on other programs, this tells you how to use lldb on ldlb and lldb-server. Lacking any Mac experience I've not included any debugserver information apart from stating it will be similar but not the same. I plan for this page to include sections on debugging tests and other things but this initial commit is purely about the two main binaries involved.
-
Stephen Tozer authored
The optnone tests, following the removal of the Dexter builder in a prior patch (45a40c16), are experiencing intermittent failures. This patch marks them unsupported to be fixed in a new commit, rather than reverting the Dexter patch.
-
Mark de Wever authored
This is a followup of D157625. Using the name clang-modules-build makes it clear this is regarding the clang modules and not the C++23 std or std.compat module. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D158927
-
Florian Hahn authored
-
Mikhail R. Gadelha authored
In patch D157792, the calls to SYS_llseek/SYS_llseek for 32-bit systems were fixed in lseek.cpp but there was another implementation in file.cpp that was missed. To reduce the code duplication, this patch unifies both call sites to use a new lseekimpl function. Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D159208
-
Aleksandr Popov authored
Currently we hoist conditions from widenable branch which are joined to the widenable_condition by And operation. E.g if we have br(WC && (c1 && c2)) we will operate with (c1 && c2) unsplitted. This patch adds more flexibility to that mechanism by supporting work with the list of checks parsed from the widenable branch. On that stage patch doesn't change the logic of checks hoisting. In the example above we will either hoist both checks [c1, c2] or none of them. But in the future we would improve that logic analyzing each check separately. Reviewed By: anna Differential Revision: https://reviews.llvm.org/D157689
-
yronglin authored
Implement LWG3938 (Cannot use std::expected monadic ops with move-only error_type) https://wg21.link/LWG3938 Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D154116
-
Jie Fu authored
/Users/jiefu/llvm-project/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:959:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default: ^ 1 error generated.
-
Stephen Tozer authored
This patch makes a further attempt to fix the tests broken by the previous revision by ensuring that the command line for the modified Dexter tests use -std=gnu++11, in keeping with the old build script. This reverts commit 5647f290.
-
MaggieYingYi authored
[llvm-cov] - Output better error message when the error kind is `coveragemap_error::malforme`. (#65264) The current llvm-cov error message for kind `coveragemap_error::malforme`, just gives the issue kind without any reason for what caused the issue. This patch is aimed at improving the llvm-cov error message to help identify what caused the issue. Reviewed By: MaskRay Close: https://github.com/llvm/llvm-project/pull/65264
-
Viktoriia Bakalova authored
Differential Revision: https://reviews.llvm.org/D159462
-
Louis Dionne authored
Differential Revision: https://reviews.llvm.org/D138528
-
Timm Bäder authored
Differential Revision: https://reviews.llvm.org/D156047
-
Louis Dionne authored
This should fix CI issues introduced by 065dc485 where the std.cppm module won't build in C++20 mode because views::chunk_by was added in C++23 but wasn't marked as such in ranges.inc.
-
NAKAMURA Takumi authored
At the moment, - Provide only `profile` - Will invoke error unless the platform is linux Differential Revision: https://reviews.llvm.org/D156095
-
Timm Bäder authored
Differential Revision: https://reviews.llvm.org/D156045
-
Kadir Cetinkaya authored
Putting preferred header signal above completeness implied we would uprank forward declarations above complete ones in certain cases. This can be desired in cases where: - Complete definition is private. But this case is already governed by publicness signal. - The library indeed intends to provide a forward declaring interface, like iosfwd vs ostream. In all other cases, upranking is undesired as it means we've picked up prefered headerness signal by mistake from an unrelated declaration to the library. This change regresses the behavior for libraries that intentionally provide a forward declaring interface. But that wasn't something we intended to support explicitly, it was working incidentally when the forward declaring header had a similar name to the symbol. Moreover, include-cleaner deliberately discourages forward-declarations, so not working in this case is also more aligned with rest of the components. Differential Revision: https://reviews.llvm.org/D159441
-
Timm Bäder authored
Differential Revision: https://reviews.llvm.org/D155627
-
Matthias Springer authored
One-Shot Bufferize correctly handles RaW conflicts around repetitive regions (loops). Specical handling is needed for parallel regions. These are a special kind of repetitive regions that can have additional RaW conflicts that would not be present if the regions would be executed sequentially. Example: ``` %0 = bufferization.alloc_tensor() scf.forall ... { %1 = linalg.fill ins(...) outs(%0) ... scf.forall.in_parallel { tensor.parallel_insert_slice %1 into ... } } ``` A separate (private) buffer must be allocated for each iteration of the `scf.forall` loop. This change adds a new interface method to `BufferizableOpInterface` to detect parallel regions. By default, regions are assumed to be sequential. A buffer is privatized if an OpOperand bufferizes to a memory read inside a parallel region that is different from the parallel region where operand's value is defined. Differential Revision: https://reviews.llvm.org/D159286 -
Simon Pilgrim authored
Assuming the ADD is nsw then it may be sign-extended to merge with a SHL op in a similar fold to the existing (shl (add x, c1), c2) -> (add (shl x, c2), c1 << c2) fold. This is most useful for helping to expose address math for X86, but has also touched several aarch64 test cases as well. Alive2: https://alive2.llvm.org/ce/z/2UpSbJ Differential Revision: https://reviews.llvm.org/D159198
-
Abhina Sree authored
On z/OS, the following error message is not matched correctly in lit tests. `EDC5129I No such file or directory.` This patch uses a lit config substitution to check for platform specific error messages.
-
Jay Foad authored
SITargetLowering::adjustWritemask calls SelectionDAG::UpdateNodeOperands to update an EXTRACT_SUBREG node in-place to refer to a new IMAGE_LOAD instruction, before we delete the old IMAGE_LOAD instruction. But in UpdateNodeOperands can do CSE on the fly and return a different EXTRACT_SUBREG node, so the original EXTRACT_SUBREG node would still exist and would refer to the old deleted IMAGE_LOAD instruction. This caused errors like: t31: v3i32,ch = <<Deleted Node!>> # D:1 This target-independent node should have been selected! UNREACHABLE executed at lib/CodeGen/SelectionDAG/InstrEmitter.cpp:1209! Fix it by detecting the CSE case and replacing all uses of the original EXTRACT_SUBREG node with the CSE'd one.
-
Viktoriia Bakalova authored
Differential Revision: https://reviews.llvm.org/D159463
-
Matthias Springer authored
scf.forall ops without shared outputs (i.e., fully bufferized ops) are lowered to scf.parallel. scf.forall ops are typically lowered by an earlier pass depending on the execution target. E.g., there are optimized lowerings for GPU execution. This new lowering is for completeness (convert-scf-to-cf can now lower all SCF loop constructs) and provides a simple CPU lowering strategy for testing purposes. scf.parallel is currently lowered to scf.for, which executes sequentially. The scf.parallel lowering could be improved in the future to run on multiple threads.
-
Eymen Ünay authored
Fix masking error in Thumb_Jump24 Fix halfword comparisons in asserts Add Data_Pointer32 to getEdgeKindName Reviewed By: sgraenitz Differential Revision: https://reviews.llvm.org/D157540
-
Tom Eccles authored
Anything that produces a hlfir.expr should have an allocation side effect so that it is not removed by CSE (which would result in two hlfir.destroy operations for the same expression). Similarly for hlfir.associate, which has hlfir.end_associate. Also adds read effects on arguments which are pointer-like or boxes. I see no regressions from this change when running llvm-testsuite with optimization enabled, or from SPEC2017 rate benchmarks. To test this, I have added MLIR's pass for testing side effect interfaces to fir-opt. Differential Revision: https://reviews.llvm.org/D158662
-
Phoebe Wang authored
m_x86_Features_Group always turn `mno-xxxx` into `-target-feature -xxxx`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`. This patch solves unexpected warning when using `mno-gather/mno-scatter`: ``` '-gather' is not a recognized feature for this target (ignoring feature) '-scatter' is not a recognized feature for this target (ignoring feature) ```
-
Luke Lau authored
V implies Zvl128b, but a lot of the fixed vector tests also redundantly specify -riscv-v-vector-bits-min=128. This patch removes them where there isn't another minimum vlen being tested for, and for cases where Zve* is being used Zvl128b was added to maintain the old test diff (and because an awkward vlen probably isn't interesting to test for). Other places where -risc-v-vector-bits-min were being used were replaced with Zvl.
-
Congcong Cai authored
`HeaderIncludes` won't update `ExistingIncludes` during inserting. We need to manage it in tidy check. Fixed: #65285
-