- Oct 27, 2021
-
-
Fangrui Song authored
-
Luke Petre authored
There is an issue where the AST code does not compute the correct SourceRange for a ObjCObjectPointer. From Richard Smith (ie @zygoloid) in discord: I think the problem is that we set an invalid location for the * (because there isn't one): https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaType.cpp#L1121 And then we use the default getLocalSourceRangeImpl for a PointerLikeTypeLoc that just assumes the * location is the type's end location: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/AST/TypeLoc.h#L1293 Possibly we should be special-casing that here: https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/TypeLoc.cpp#L228 My change: introduces a AST dump test to show the issue in the first commit special cases ObjCObjectPointerType in the second commit to correctly compute the end location
-
Zahira Ammarguellat authored
-
zhijian authored
address an test error on window os , exclude the test llvm/test/tools/llvm-readobj/XCOFF/xcoff-auxiliary-header.test from windows OS. http://45.33.8.238/win/47662/step_11.txt for https://reviews.llvm.org/D82549
-
Dmitry Vyukov authored
This reverts commit 5ec83226. It broke a number of bots, e.g.: https://lab.llvm.org/buildbot/#/builders/52/builds/11811 Reviewed By: melver Differential Revision: https://reviews.llvm.org/D112563
-
Joe Loser authored
Mark LWG2731 as complete. The type alias `mutex_type` is only provided if `scoped_lock` is given one mutex type and it has been implemented that way since the beginning of Clang 5 it seems. There already are tests for verifying existence (and lack thereof) for `mutex_type` type alias depending on the number of mutex types, so there is nothing to do for this LWG issue. Reviewed By: Quuxplusone, Mordante, #libc Differential Revision: https://reviews.llvm.org/D112462
-
Chia-hung Duan authored
Added a notification in the placeholder section. While writing things like preciate of an attribute, we may embed certain placeholder in the C expression. Note that the type of the placeholder is only guaranteed to be the base type like mlir::Type, it's better not to use the derived type which is based on the implementation. Reviewed By: mehdi_amini Differential Revision: https://reviews.llvm.org/D112396
-
Usman Nadeem authored
Change-Id: Idcce321c825ecc6b3a111a683e24dc10015f6872
-
Alexey Bataev authored
-
Stanislav Mekhanoshin authored
-
Louis Dionne authored
This patch refactors the shared_ptr methods from being defined out-of-line to being defined inline in the class, like what we do for all new code in the library. The benefits of doing that are that code is not as scattered around and is hence easier to understand, and it avoids a ton of duplication due to SFINAE checks. Defining the method where it is declared also removes the possibility for mismatched attributes. As a fly-by change, this also: - Adds a few _LIBCPP_HIDE_FROM_ABI attributes - Uses __enable_if_t instead of enable_if as a function argument, to match the style that we use everywhere else. Differential Revision: https://reviews.llvm.org/D112478
-
Usman Nadeem authored
These are now redundant after https://reviews.llvm.org/D106872 Change-Id: I82edfedf1d45cac4e3368d77ce3a48c78e342c19
-
Rosie Sumpter authored
Use RdxDesc->getOpcode instead of getUnderlingInstr()->getOpcode. Move the code which finds Kind and IsOrdered to be outside the for loop since neither of these change with the vector part. Differential Revision: https://reviews.llvm.org/D112547
-
Balazs Benics authored
It seems like protobuf crashed the `std::string` checker. Somehow it acquired `UnknownVal` as the sole `std::string` constructor parameter, causing a crash in the `castAs<Loc>()`. This patch addresses this. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D112551
-
- Oct 26, 2021
-
-
Amy Zhuang authored
1.Combining kind min/max of Vector reduction op has been changed to minf/maxf, minsi/maxsi, and minui/maxui. Modify getVectorReductionOp accordingly. 2.Add min/max to supported reductions. Reviewed By: dcaballe, nicolasvasilache Differential Revision: https://reviews.llvm.org/D112246
-
- Oct 27, 2021
-
-
Kazu Hirata authored
-
- Oct 26, 2021
-
-
Florian Hahn authored
This patch implements __builtin_elementwise_max and __builtin_elementwise_min, as specified in D111529. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D111985
-
Sanjay Patel authored
-
Jez Ng authored
We were previously always emitting the GOT into `__DATA_CONST`, even for target platforms where it should end up in `__DATA`. I stumbled onto this while trying to use the `class-dump` tool -- with the wrong segment names, it fails to locate the ObjC runtime info and therefore fails to dump any classes. Reviewed By: #lld-macho, oontvoo Differential Revision: https://reviews.llvm.org/D112500
-
Adam Czachorowski authored
Before this change, we would add "using std::vector<int>" instead of just "using std::vector;", which would not even compile. Fixes https://github.com/clangd/clangd/issues/904 Differential Revision: https://reviews.llvm.org/D112530
-
Adam Czachorowski authored
We make assumption that: getDeclForComment(getDeclForComment(X)) == getDeclForComment(X) but this is not true if you have a template instantionation of a template instantiation, which is the case when, for example, you have a <=> operator in a templated class. This fix makes getDeclForComment() call itself recursively to ensure this property is always true. Fixes https://github.com/clangd/clangd/issues/901 Differential Revision: https://reviews.llvm.org/D112527
-
Kirill Bobyrev authored
This is inconsistent with the code and comments in RecursiveASTVisitor.h and is not a correct behavior: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/AST/RecursiveASTVisitor.h#L1879-L1880 > We shouldn't traverse D->getTypeForDecl(); it's a result of > declaring the type, not something that was written in the source. Fixes the failures in 1c2e249f
-
Matt Morehouse authored
Verify that SecondII is not replaced.
-
Jonas Paulsson authored
It was discovered that an extra register COPY remained when expanding a (variable length) memory operation with a loop and there was another use of the involved address register(s) afterwards. A simple fix for this is to COPY the address registers before the loop and use that new vreg instead. Review: Ulrich Weigand Differential Revision: https://reviews.llvm.org/D112065
-
Alexey Bataev authored
The final reduction nodes should not be reordered, the order does not matter for reductions. Also, it might be profitable to vectorize smaller reduction trees, reduction cost may compensate small tree cost. Part of D111574 Differential Revision: https://reviews.llvm.org/D112467
-
zhijian authored
Summary: The patch supports parsing the xcoff object file auxiliary header with llvm-readobj with option "auxiliary-headers" the format of auxiliary header as https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/filesreference/XCOFF.html#XCOFF__fyovh386shar Reviewers: James Henderson, Jason Liu, Hubert Tong, Esme yi, Sean Fertile. Differential Revision: https://reviews.llvm.org/D82549
-
Florian Hahn authored
This patch specifies a set of vector builtins for Clang, as discussed on cfe-dev: https://lists.llvm.org/pipermail/cfe-dev/2021-September/068999.html https://lists.llvm.org/pipermail/cfe-dev/2021-October/069070.html Reviewed By: scanon Differential Revision: https://reviews.llvm.org/D111529
-
Louis Dionne authored
This was forgotten when setting up the from-scratch configs. Differential Revision: https://reviews.llvm.org/D112460
-
Dmitry Vyukov authored
All tsan interceptors check for initialization and/or initialize things as necessary lazily, so we can pretend everything is initialized in the COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED check to avoid double-checking for initialization (this is only necessary for sanitizers that don't handle initialization on common grounds). Reviewed By: melver Differential Revision: https://reviews.llvm.org/D112446
-
Dmitry Vyukov authored
Print PC of the previous lock, not the current one. The current one will be printed during unwind. Reviewed By: melver Differential Revision: https://reviews.llvm.org/D112533
-
Kirill Bobyrev authored
I was under the impression that `return false;` in the RecursiveASTVisitor stops the traversal for the subtree but it appears that it stops the whole tree traversal, so this change introduces a bug where `ReferencedLocationCrawler` will not collect any symbols past an enum. This is a follow-up on D112209.
-
Neubauer, Sebastian authored
CSR_AMDGPU_VGPRs_24_255 and CSR_AMDGPU_VGPRs_32_255 are not used anywhere, so remove them. Differential Revision: https://reviews.llvm.org/D112535
-
Ron Lieberman authored
add support for ROCR_VISIBLE_DEVICES similar to name and purpose as CUDA_VISIBLE_DEVICES Differential Revision: https://reviews.llvm.org/D112503
-
Nico Weber authored
@finally is still not implemented. With this, clang can emit -Wreturn-type warnings for functions containing @try/@catch (but not yet @finally), and -Wunreachable-code also works for those functions. The implementation is similar to D36914. Part of PR46693. Differential Revision: https://reviews.llvm.org/D112287
-
Nico Weber authored
No behavior change.
-
Nico Weber authored
No behavior change.
-
Nico Weber authored
No behavior change.
-
Abinav Puthan Purayil authored
The motivation for this is due to clang's conformance to https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_C.html#operators-shift which makes clang emit (<shift> a, (and b, <width> - 1)) for `a <shift> b` in OpenCL where a is an int of bit width <width>. Differential revision: https://reviews.llvm.org/D110231
-
Louis Dionne authored
Summary: This commit switches libunwind from using the complicated logic in libc++'s testing configuration to a from-scratch configuration. I tried to make sure that all cases that were handled in the old config were handled by this one too, so hopefully this shouldn't break anyone. However, if you encounter issues with this change, please let me know and feel free to revert if I don't reply quickly. This change was engineered to be easily revertable. This commit is a re-application of 5a8ad80b, which was reverted in 070a2ddc because it broke the Bootstrapping build. This has now been addressed by tweaking the from-scratch config. Differential Revision: https://reviews.llvm.org/D112082
-
Chen Zheng authored
Fix an issue caused by D108750 Reviewed By: nemanjai Differential Revision: https://reviews.llvm.org/D112502
-