1. Mar 19, 2021
    • Wei Mi's avatar
      [SampleFDO] Don't mix up the existing indirect call value profile with the new · 14756b70
      Wei Mi authored
      value profile annotated after inlining.
      
      In https://reviews.llvm.org/D96806 and https://reviews.llvm.org/D97350, we
      use the magic number -1 in the value profile to avoid repeated indirect call
      promotion to the same target for an indirect call. Function updateIDTMetaData
      is used to mark an target as being promoted in the value profile with the
      magic number. updateIDTMetaData is also used to update the value profile
      when an indirect call is inlined and new inline instance profile should be
      applied. For the second case, currently updateIDTMetaData mixes up the
      existing value profile of the indirect call with the new profile, leading
      to the problematic senario that a target count is larger than the total count
      in the value profile.
      
      The patch fixes the problem. When updateIDTMetaData is used to update the
      value profile after inlining, all the values in the existing value profile
      will be dropped except the values with the magic numbe...
      14756b70
    • Mircea Trofin's avatar
      Reapply "[NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes" · 92ccc6cb
      Mircea Trofin authored
      This reverts commit 11b70b9e.
      
      The bot failure was due to ArgumentPromotion deleting functions
      without deleting their analyses. This was separately fixed in 4b1c8070.
      92ccc6cb
    • Ricky Taylor's avatar
      Test commit · 6dad3445
      Ricky Taylor authored
      This is a test commit to verify my access.
      6dad3445
    • Mircea Trofin's avatar
      [NFC][ArgumentPromotion] Clear FAM cached results of erased function. · 4b1c8070
      Mircea Trofin authored
      Not doing it here can lead to subtle bugs - the analysis results are
      associated by the Function object's address. Nothing stops the memory
      allocator from allocating new functions at the same address.
      4b1c8070
    • Mike Rice's avatar
      [OPENMP51]Support for the 'destroy' clause with interop variable. · c2f8e158
      Mike Rice authored
      Added basic parsing/sema/serialization support to extend the
      existing 'destroy' clause for use with the 'interop' directive.
      
      Differential Revision: https://reviews.llvm.org/D98834
      c2f8e158
    • Chris Lattner's avatar
      [libsupport] Silence a bogus valgrind warning. · ced72567
      Chris Lattner authored
      Valgrind is reporting this bogus warning because it doesn't model
      pthread_sigmask fully accurately.  This is a valgrind bug, but
      silencing it has effectively no cost, so just do it.
      
      ==73662== Syscall param __pthread_sigmask(set) points to uninitialised byte(s)
      ==73662==    at 0x101E9D4C2: __pthread_sigmask (in /usr/lib/system/libsystem_kernel.dylib)
      ==73662==    by 0x101EFB5EA: pthread_sigmask (in /usr/lib/system/libsystem_pthread.dylib)
      ==73662==    by 0x1000D9F6D: llvm::sys::Process::SafelyCloseFileDescriptor(int) (in /Users/chrisl/Projects/circt/build/bin/firtool)
      ==73662==    by 0x100072795: llvm::ErrorOr<std::__1::unique_ptr<llvm::MemoryBuffer, std::__1::default_delete<llvm::MemoryBuffer> > > getFileAux<llvm::MemoryBuffer>(llvm::Twine const&, long long, unsigned long long, unsigned long long, bool, bool) (in /Users/chrisl/Projects/circt/build/bin/firtool)
      ==73662==    by 0x100072573: llvm::MemoryBuffer::getFileOrSTDIN(llvm::Twine const&, long long, bool) (in /Users/chrisl/Projects/circt/build/bin/firtool)
      ==73662==    by 0x100282C25: mlir::openInputFile(llvm::StringRef, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) (in /Users/chrisl/Projects/circt/build/bin
      
      Differential Revision: https://reviews.llvm.org/D98830
      ced72567
    • Stanislav Mekhanoshin's avatar
  2. Mar 18, 2021