[ADT] Fix llvm::join on containers of char*s (#67113)

Currently it tries to call S.size() when preallocating the target
string,
which doesn't compile.
vector<const char*> is used a bunch in e.g. clang driver.