[mlir] more side effect verification in transform dialect
Add a verifier checking that if a transform operation consumes a handle (which is associated with a payload operation being erased or recreated), it also indicates modification of the payload IR. This hasn't been consistent in the past because of the "no-aliasing" assumption where we couldn't have had more than one handle to an operation, requiring some handle-manipulation operations, such as `transform.merge_handles` to consume their operands. That assumption has been liften and it is no longer necessary for these operations to consume handles and thus make the life harder for the clients. Additionally, remove TransformEffects.td that uses the ODS mechanism for indicating side effects that works only for operands and results. It was being used incorrectly to also indicate effects on the payload IR, not assocaited with any IR value, and lacked the consume/produce semantics available via helpers in C++. Reviewed By: nicolasvasilache Differential Revision: https://reviews.llvm.org/D142361
parent
6da0184b
Please register or sign in to comment