- Jun 02, 2014
-
-
Stephen M. Cameron authored
CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL do not require rescans to be initiated. Current firmware filters out these events already, but some out of date firmware doesn't, so the driver needs to filter them out too. Without this change and with out of date firmware you may see the driver spending a lot of time scanning devices unnecessarily on some Smart Arrays. Signed-off-by:
Stephen M. Cameron <scameron@beardog.cce.hp.com> Reviewed-by:
Justin Lindley <justin.lindley@hp.com> Signed-off-by:
Christoph Hellwig <hch@lst.de>
-
Stephen M. Cameron authored
There's nothing the user can or should do about these messages, the commands are retried down the normal RAID path, and the messages just flood the logs and sap performance. Signed-off-by:
Joe Handzik <joseph.t.handzik@hp.com> Reviewed-by:
Mike Miller <michael.miller@canonical.com> Signed-off-by:
-
Stephen M. Cameron authored
Signed-off-by:
-
Stephen M. Cameron authored
Signed-off-by:
-
Stephen M. Cameron authored
for controllers which support either of the ioaccel transport methods. Signed-off-by:
-
Stephen M. Cameron authored
Avoid excessive locking by using per-cpu variable for lockup_detected Signed-off-by:
Scott Teel <scott.teel@hp.com> Signed-off-by:
-
Stephen M. Cameron authored
Signed-off-by:
-
Stephen M. Cameron authored
Now that we can allocate more than 4 reply queues (up to 64) we shouldn't try to make them share the same allocation but should allocate them separately. Signed-off-by:
-
Stephen M. Cameron authored
No sense having 8 or 16 reply queues if you only have 4 cpus, and likewise no sense limiting to 8 reply queues if you have many more cpus. Signed-off-by:
-
Stephen M. Cameron authored
They are not completely free of cost when disabled and when enabled emitting debug output for every command submitted produces far too much output to be useful. Signed-off-by:
Webb Scales <webb.scales@hp.com> Signed-off-by:
-
Stephen M. Cameron authored
Signed-off-by:
-
Justin Lindley authored
After 3.22 firmware, PMC firmware guys tell us the previous 5 second delay after a reset now needs to be 10 secs to avoid a PCIe error due to the driver looking at the controller too soon after the reset. Signed-off-by:
-
Stephen M. Cameron authored
Treat the the data direction bits as a bit mask allowing both READ and WRITE at the same time instead of testing for equality to see if it's a exclusively a READ or a WRITE. Signed-off-by:
-
Stephen M. Cameron authored
The fields "major", "max_outstanding", and "usage_count" of struct ctlr_info were not used for anything. Signed-off-by:
-
Ben Hutchings authored
Matt Taggart reported that mvsas didn't bind to the Marvell SAS controller on a Supermicro AOC-SAS2LP-MV8 board. lspci reports it as: 01:00.0 RAID bus controller [0104]: Marvell Technology Group Ltd. Device [1b4b:9485] (rev 03) Subsystem: Marvell Technology Group Ltd. Device [1b4b:9485] [...] Add it to the device table as chip_9485. Signed-off-by:Ben Hutchings <ben@decadent.org.uk> Reported-by:
Matt Taggart <taggart@debian.org> Tested-by:
Jan "Yenya" Kasprzak <kas@fi.muni.cz> Signed-off-by:
-
Christoph Hellwig authored
This reverts commit 11206081. Based on comments from Mike Christie and Sony John-N.
-
- May 29, 2014
-
-
Tomas Henzl authored
Hi, without this patch the istwiRWRequest->MsgContext is always set to zero, this patch saves the MsgContext in a msgcontext variable and then restores the value. Thanks to David Jeffery who found the issue and did the analysis. Signed-off-by:
Tomas Henzl <thenzl@redhat.com> Acked-by:
Desai, Kashyap <Kashyap.Desai@lsi.com> Signed-off-by:
-
Paul Bolle authored
The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always triggered a preprocessor error if CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see, it has never even been possible to set SCSI_ACORNSCSI_LINK through kconfig, or its predecessors, in the first place. Let's remove the code involved. Signed-off-by:
Paul Bolle <pebolle@tiscali.nl> Acked-by:
Russell King <rmk+kernel@arm.linux.org.uk> Acked-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
-
Finn Thain authored
This is the delta between the two submissions: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure and [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure The macro definition changes were discussed on the mailing list during review. The idea is to get the compiler to check the parameters of disabled printk() calls so that the debugging code doesn't rot again. Signed-off-by:
Finn Thain <fthain@telegraphics.com.au> Signed-off-by:
-
Matthew Wilcox authored
Removing the host_lock from the I/O submission path gives a huge scalability improvement. Signed-off-by:
Matthew Wilcox <matthew.r.wilcox@intel.com> Reviewed-by:
Nicholas Bellinger <nab@linux-iscsi.org> Reviewed-by:
Praveen Krishnamoorthy <Praveen.krishnamoorthy@lsi.com> Acked-by:
Sreekanth Reddy <Sreekanth.reddy@lsi.com> Signed-off-by:
-
Matthew Wilcox authored
Reusing a msg frame quickly means it's still cache-hot. This yields a small but noticable performance improvement in a well-known database benchmark. This improvement is already present in the mpt3sas driver. Signed-off-by:
-
Matthew Wilcox authored
Reusing a smid quickly means it's still cache-hot. This yields a small but noticable performance improvement in a well-known database benchmark. This improvement is already present in the mpt3sas driver. Signed-off-by:
-
Matthew Wilcox authored
Removing the host_lock from the I/O submission path gives a huge scalability improvement. Signed-off-by:
-
Matthew Wilcox authored
The mpt2sas_scsih_issue_tm() function does not use the 'serial_number' argument passed to it. Removing it removes the last vestiges of the scsi_cmnd's serial_number field from this driver. Signed-off-by:
-
Matthew Wilcox authored
Removing the host_lock from the I/O submission path gives a huge scalability improvement. Signed-off-by:
-
Matthew Wilcox authored
The mpt3sas_scsih_issue_tm() function does not use the 'serial_number' argument passed to it. Removing it removes the last vestiges of the scsi_cmnd's serial_number field from this driver. Signed-off-by:
-
Benoit Taine authored
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci Signed-off-by:
Benoit Taine <benoit.taine@lip6.fr> Acked-by:
Saurav Kashyap <saurav.kashyap@qlogic.com> Signed-off-by:
-
Benoit Taine authored
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci Signed-off-by:
Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by:
-
Dan Carpenter authored
There are missing curly braces here so it prints that the recovery failed even when it succeeded. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Giridhar Malavali <giridhar.malavali@qlogic.com> Acked-by:
Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by:
-
Jayamohan Kallickal authored
Bumping the driver version. Signed-off-by:
John Soni Jose <sony.john-n@emulex.com> Signed-off-by:
Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by:
-
Jayamohan Kallickal authored
During heavy IO in multipath environment with many active sessions and port-bouncing happening, there is a race condition because of which beiscsi_prcess_cqe() gets called for a connection whose endpoint is freed. Checking endpoint reference for a connection before processing in beiscsi_process_cq(). Signed-off-by:
Minh Tran <minhduc.tran@emulex.com> Signed-off-by:
-
Jayamohan Kallickal authored
EQ teardown should happen only after all CQ are destroyed. In some FW config, adapter goes into a freeze state. This fix moves teardown of MCC-Q before the EQ teardown happens. Signed-off-by:
-
Jayamohan Kallickal authored
From: Dan Carpenter [mailto:dan.carpenter@oracle.com] Sent: Friday, March 28, 2014 1:42 AM Subject: re: [SCSI] be2iscsi: Fix handling timed out MBX completion from FW Hello Jayamohan Kallickal, The patch 1957aa7f : "[SCSI] be2iscsi: Fix handling timed out MBX completion from FW" from Jan 29, 2014, leads to the following static checker warning: drivers/scsi/be2iscsi/be_main.c:5581 beiscsi_dev_probe() error: memset() '&phba->ctrl.ptag_state[i]->tag_mem_state' too small (24 vs 32) drivers/scsi/be2iscsi/be_main.c 5576 for (i = 0; i < MAX_MCC_CMD; i++) { 5577 init_waitqueue_head(&phba->ctrl.mcc_wait[i + 1]); 5578 phba->ctrl.mcc_tag[i] = i + 1; 5579 phba->ctrl.mcc_numtag[i + 1] = 0; 5580 phba->ctrl.mcc_tag_available++; 5581 memset(&phba->ctrl.ptag_state[i].tag_mem_state, 0, 5582 sizeof(struct beiscsi_mcc_tag_state)); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Probably this this be change to sizeof(struct be_dma_mem struct)? It looks like we are corrupting memory a bit here. 5583 } regards, dan carpenter Reported-by:
-
Jayamohan Kallickal authored
SKH-R adapter, TCP Window Size/Scale parameters are passed in TCP Connection Offload Mbx Command. Signed-off-by:
-
Jayamohan Kallickal authored
Signed-off-by:
-
Jayamohan Kallickal authored
Before probe for function was completed, iSCSI Daemon had initiated login to target while OS was coming up. The targets which had node.startup=automatic, login process was initiated.Since function specific initialization was still in progress this lead to kernel panic. Fixed the issue by moving iscsi_host_add() call after adapter initialization is done. Signed-off-by:
-
Jayamohan Kallickal authored
Getting WRB for MCCQ posting was done before looking if tag is available or not. This lead to increase phba->ctrl.mcc_obj.q.used variable and the WARN_ON message was coming from wrb_from_mccq(). Moved getting wrb from mccq after checking for the tag. In wrb_from_mccq(), memset is done before returning wrb ptr. Removed memset of mccq wrb from all other functions. Signed-off-by:
-
- May 28, 2014
-
-
Sujit Reddy Thumma authored
Error handling in UFS driver is broken and resets the host controller for fatal errors without re-initialization. Correct the fatal error handling sequence according to UFS Host Controller Interface (HCI) v1.1 specification. o Processed requests which are completed w/wo error are reported to SCSI layer and any pending commands that are not started are aborted in the controller and re-queued into scsi mid-layer queue. o Upon determining fatal error condition the host controller may hang forever until a reset is applied. Block SCSI layer for sending new requests and apply reset in a separate error handling work. o SCSI is informed about the expected Unit-Attention exception from the device for the immediate command after a reset so that the SCSI layer take necessary steps to establish communication with the device. Signed-off-by:
Sujit Reddy Thumma <sthumma@codeaurora.org> Reviewed-by:
Yaniv Gardi <ygardi@codeaurora.org> Tested-by:
Dolev Raviv <draviv@codeaurora.org> Acked-by:
Vinayak Holikatti <vinholikatti@gmail.com> Signed-off-by:
-
Sujit Reddy Thumma authored
As of now SCSI initiated error handling is broken because, the reset APIs don't try to bring back the device initialized and ready for further transfers. In case of timeouts, the scsi error handler takes care of handling aborts and resets. Improve the error handling in such scenario by resetting the device and host and re-initializing them in proper manner. Signed-off-by:
-
Sujit Reddy Thumma authored
There is a possible race condition in the hardware when the abort command is issued to terminate the ongoing SCSI command as described below: - A bit in the door-bell register is set in the controller for a new SCSI command. - In some rare situations, before controller get a chance to issue the command to the device, the software issued an abort command. - If the device recieves abort command first then it returns success because the command itself is not present. - Now if the controller commits the command to device it will be processed. - Software thinks that command is aborted and proceed while still the device is processing it. - The software, controller and device may go out of sync because of this race condition. To avoid this, query task presence in the device before sending abort task command so that after the abort operation, the command is guaranteed to be non-existent in both controller and the device. Signed-off-by:
-
