Commit fd8a44bd authored Mar 21, 2019 by Kishon Vijay Abraham I Committed by Lorenzo Pieralisi Apr 04, 2019

PCI: dwc: Remove default MSI initialization for platform specific MSI chips



Platforms which populate msi_host_init() have their own MSI controller
logic. Writing to MSI control registers on platforms which do not use
Designware's MSI controller logic might have side effects.

To be safe, do not write to MSI control registers if the platform uses
its own MSI controller logic instead of Designware's MSI one.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

parent dad52589

drivers/pci/controller/dwc/pcie-designware-host.c

+13 −11

Original line number	Diff line number	Diff line
		@@ -626,6 +626,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp)

		dw_pcie_setup(pci);

		if (!pp->ops->msi_host_init) {
		num_ctrls = pp->num_vectors / MAX_MSI_IRQS_PER_CTRL;

		/* Initialize IRQ Status array */
		@@ -638,6 +639,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp)
		(ctrl * MSI_REG_CTRL_BLOCK_SIZE),
		4, ~0);
		}
		}

		/* Setup RC BARs */
		dw_pcie_writel_dbi(pci, PCI_BASE_ADDRESS_0, 0x00000004);