Commit eb40a380 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpuidle: menu: Do not update last_state_idx in menu_select() 



It is not necessary to update data->last_state_idx in menu_select()
as it only is used in menu_update() which only runs when
data->needs_update is set and that is set only when updating
data->last_state_idx in menu_reflect().

Accordingly, drop the update of data->last_state_idx from
menu_select() and get rid of the (now redundant) "out" label
from it.

No intentional behavior changes.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 96c3d11d

drivers/cpuidle/governors/menu.c

+2 −5
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, 
			    s->target_residency <= ktime_to_us(delta_next))

				idx = i;



			goto out;

			return idx;

		}

		if (s->exit_latency > latency_req) {

			/*
@@ -445,10 +445,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, 
		}

	}



out:

	data->last_state_idx = idx;



	return data->last_state_idx;

	return idx;

}



/**