Commit e21bf338 authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Greg Kroah-Hartman
Browse files

staging: lustre: remove extra parentheses around left bit shift operations 



Removes extra parentheses around bitwise left shift operations.
The cases handled here are when resultant values are assigned to
variables. The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);

Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9ea755f3

drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c

+3 −3
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static int typed_conns = 1; 
module_param(typed_conns, int, 0444);

MODULE_PARM_DESC(typed_conns, "use different sockets for bulk");



static int min_bulk = (1<<10);

static int min_bulk = 1<<10;

module_param(min_bulk, int, 0644);

MODULE_PARM_DESC(min_bulk, "smallest 'large' message");
@@ -122,7 +122,7 @@ static int nonblk_zcack = 1; 
module_param(nonblk_zcack, int, 0644);

MODULE_PARM_DESC(nonblk_zcack, "always send ZC-ACK on non-blocking connection");



static unsigned int zc_min_payload = (16 << 10);

static unsigned int zc_min_payload = 16 << 10;

module_param(zc_min_payload, int, 0644);

MODULE_PARM_DESC(zc_min_payload, "minimum payload size to zero copy");
@@ -182,7 +182,7 @@ int ksocknal_tunables_init(void) 
#endif



	if (*ksocknal_tunables.ksnd_zc_min_payload < (2 << 10))

		*ksocknal_tunables.ksnd_zc_min_payload = (2 << 10);

		*ksocknal_tunables.ksnd_zc_min_payload = 2 << 10;



	return 0;

};