Commit 9ea755f3 authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Greg Kroah-Hartman
Browse files

staging: xgifb: remove extra parentheses around right bit shift operations 



Removes extra parentheses around bitwise right shift operations.
The cases handled here are when resultant values are assigned to
variables. The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
>>
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
>>
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
>>
-c)
+c
,...);

Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6de3f58b

drivers/staging/xgifb/XGI_main_26.c

+3 −3
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ static int XGIfb_mode_rate_to_ddata(struct vb_device_info *XGI_Pr, 


	sr_data = XGI_CRT1Table[index].CR[5];



	HDE = (XGI330_RefIndex[RefreshRateTableIndex].XRes >> 3);

	HDE = XGI330_RefIndex[RefreshRateTableIndex].XRes >> 3;



	cr_data = XGI_CRT1Table[index].CR[3];
@@ -1011,8 +1011,8 @@ static int XGIfb_do_set_var(struct fb_var_screeninfo *var, int isactive, 
			       XGIbios_mode[xgifb_info->mode_idx].mode_no);

			return -EINVAL;

		}

		info->fix.line_length = ((info->var.xres_virtual

				* info->var.bits_per_pixel) >> 6);

		info->fix.line_length = (info->var.xres_virtual

				* info->var.bits_per_pixel) >> 6;



		xgifb_reg_set(XGISR, IND_SIS_PASSWORD, SIS_PASSWORD);