Commit dbc9eb5a authored Mar 04, 2015 by Aya Mahfouz Committed by Greg Kroah-Hartman Mar 06, 2015

staging: ozwpan: remove extra parentheses around left bit shift operations



Removes extra parentheses around bitwise left shift operations.
The case handled is when resultant value is assigned to a variable.
The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e21bf338

drivers/staging/ozwpan/ozproto.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -98,7 +98,7 @@ static void oz_send_conn_rsp(struct oz_pd *pd, u8 status)
		kfree_skb(skb);
		return;
		}
		oz_hdr->control = (OZ_PROTOCOL_VERSION<<OZ_VERSION_SHIFT);
		oz_hdr->control = OZ_PROTOCOL_VERSION<<OZ_VERSION_SHIFT;
		oz_hdr->last_pkt_num = 0;
		put_unaligned(0, &oz_hdr->pkt_num);
		elt->type = OZ_ELT_CONNECT_RSP;