Commit ca4fb89a authored by Tianjia Zhang's avatar Tianjia Zhang Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba() 

On an error exit path, a negative error code should be returned instead of
a positive return value.

Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com


Fixes: 8777e431 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent bbf2d06a

drivers/scsi/qla2xxx/qla_nvme.c

+1 −1
Original line number Diff line number Diff line
@@ -678,7 +678,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha) 
	struct nvme_fc_port_template *tmpl;

	struct qla_hw_data *ha;

	struct nvme_fc_port_info pinfo;

	int ret = EINVAL;

	int ret = -EINVAL;



	if (!IS_ENABLED(CONFIG_NVME_FC))

		return ret;