Commit bbf2d06a authored by Tianjia Zhang's avatar Tianjia Zhang Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg() 

In the case of a failed retry, a positive value EIO is returned here.  I
think this is a typo error. It is necessary to return an error value.

[mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up
to be consistent]

Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com


Fixes: 0691094f ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8905cbda

drivers/scsi/qla2xxx/qla_target.c

+1 −1
Original line number Diff line number Diff line
@@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha, 
		/* found existing exchange */

		qpair->retry_term_cnt++;

		if (qpair->retry_term_cnt >= 5) {

			rc = EIO;

			rc = -EIO;

			qpair->retry_term_cnt = 0;

			ql_log(ql_log_warn, vha, 0xffff,

			    "Unable to send ABTS Respond. Dumping firmware.\n");