Commit c16904b0 authored by Evan Quan's avatar Evan Quan Committed by Alex Deucher
Browse files

drm/amd/powerplay: correct the way for checking SMU_FEATURE_BACO_BIT support 



Since 'smu_feature_is_enabled(smu, SMU_FEATURE_BACO_BIT)' will always return
false considering the 'smu_system_features_control(smu, false)' disabled
all SMU features.

Signed-off-by: default avatarEvan Quan <evan.quan@amd.com>
Reviewed-by: default avatarKenneth Feng <kenneth.feng@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 434cbcb1

drivers/gpu/drm/amd/powerplay/amdgpu_smu.c

+12 −1
Original line number Diff line number Diff line
@@ -1488,7 +1488,18 @@ static int smu_disable_dpm(struct smu_context *smu) 


	/* For baco, need to leave BACO feature enabled */

	if (use_baco) {

		if (smu_feature_is_enabled(smu, SMU_FEATURE_BACO_BIT)) {

		/*

		 * Correct the way for checking whether SMU_FEATURE_BACO_BIT

		 * is supported.

		 *

		 * Since 'smu_feature_is_enabled(smu, SMU_FEATURE_BACO_BIT)' will

		 * always return false as the 'smu_system_features_control(smu, false)'

		 * was just issued above which disabled all SMU features.

		 *

		 * Thus 'smu_feature_get_index(smu, SMU_FEATURE_BACO_BIT)' is used

		 * now for the checking.

		 */

		if (smu_feature_get_index(smu, SMU_FEATURE_BACO_BIT) >= 0) {

			ret = smu_feature_set_enabled(smu, SMU_FEATURE_BACO_BIT, true);

			if (ret) {

				pr_warn("set BACO feature enabled failed, return %d\n", ret);