Commit 434cbcb1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher
Browse files

drm/amdgpu: return -EFAULT if copy_to_user() fails 



The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return a negative error code to the user.

Fixes: 030d5b97 ("drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_vram_read")
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 72b4c01d

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+2 −4
Original line number Diff line number Diff line
@@ -2290,7 +2290,6 @@ static ssize_t amdgpu_ttm_vram_read(struct file *f, char __user *buf, 
{

	struct amdgpu_device *adev = file_inode(f)->i_private;

	ssize_t result = 0;

	int r;



	if (size & 0x3 || *pos & 0x3)

		return -EINVAL;
@@ -2304,9 +2303,8 @@ static ssize_t amdgpu_ttm_vram_read(struct file *f, char __user *buf, 
		uint32_t value[AMDGPU_TTM_VRAM_MAX_DW_READ];



		amdgpu_device_vram_access(adev, *pos, value, bytes, false);

		r = copy_to_user(buf, value, bytes);

		if (r)

			return r;

		if (copy_to_user(buf, value, bytes))

			return -EFAULT;



		result += bytes;

		buf += bytes;