Commit a0648724 authored Mar 04, 2015 by Aya Mahfouz Committed by Greg Kroah-Hartman Mar 06, 2015

staging: unisys: virthba: remove extra parentheses around left bit shift operations



Removes extra parentheses around bitwise left shift operations.
The case handled is when resultant value is assigned to a variable.
The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6e28c2a2

drivers/staging/unisys/virthba/virthba.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1534,7 +1534,7 @@ virthba_serverdown_complete(struct work_struct *work)
		switch (pendingdel->cmdtype) {
		case CMD_SCSI_TYPE:
		scsicmd = (struct scsi_cmnd *)pendingdel->sent;
		scsicmd->result = (DID_RESET << 16);
		scsicmd->result = DID_RESET << 16;
		if (scsicmd->scsi_done)
		scsicmd->scsi_done(scsicmd);
		break;