Commit 6e28c2a2 authored Mar 04, 2015 by Aya Mahfouz Committed by Greg Kroah-Hartman Mar 06, 2015

staging: slicoss: remove extra parentheses around left bit shift operations



Removes extra parentheses around bitwise left shift operations.
The case handled is when resultant value is assigned to a variable.
The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5a80ee6f

drivers/staging/slicoss/slicoss.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1850,7 +1850,7 @@ static void slic_xmit_build_request(struct adapter *adapter,

		ihcmd = &hcmd->cmd64;

		ihcmd->flags = (adapter->port << IHFLG_IFSHFT);
		ihcmd->flags = adapter->port << IHFLG_IFSHFT;
		ihcmd->command = IHCMD_XMT_REQ;
		ihcmd->u.slic_buffers.totlen = skb->len;
		phys_addr = pci_map_single(adapter->pcidev, skb->data, skb->len,