Commit 6de3f58b authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Greg Kroah-Hartman
Browse files

staging: speakup: remove extra parentheses around right bit shift operation 



Removes extra parentheses around bitwise right shift operation.
The case handled is  when the resultant value is assigned to
a variable. The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
>>
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
>>
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
>>
-c)
+c
,...);

Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a659b3e8

drivers/staging/speakup/main.c

+1 −1
Original line number Diff line number Diff line
@@ -1527,7 +1527,7 @@ static void update_color_buffer(struct vc_data *vc, const char *ic, int len) 
	int i, bi, hi;

	int vc_num = vc->vc_num;



	bi = ((vc->vc_attr & 0x70) >> 4);

	bi = (vc->vc_attr & 0x70) >> 4;

	hi = speakup_console[vc_num]->ht.highsize[bi];



	i = 0;