Commit 854b6705 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio:light:tsl2563: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc 



Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of #ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Vaishnav M A <vaishnav@beagleboard.org>
Reviewed-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-28-jic23@kernel.org
parent 54edb876

drivers/iio/light/tsl2563.c

+3 −7
Original line number Diff line number Diff line
@@ -814,7 +814,6 @@ static int tsl2563_remove(struct i2c_client *client) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int tsl2563_suspend(struct device *dev)

{

	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -857,11 +856,8 @@ static int tsl2563_resume(struct device *dev) 
	return ret;

}



static SIMPLE_DEV_PM_OPS(tsl2563_pm_ops, tsl2563_suspend, tsl2563_resume);

#define TSL2563_PM_OPS (&tsl2563_pm_ops)

#else

#define TSL2563_PM_OPS NULL

#endif

static DEFINE_SIMPLE_DEV_PM_OPS(tsl2563_pm_ops, tsl2563_suspend,

				tsl2563_resume);



static const struct i2c_device_id tsl2563_id[] = {

	{ "tsl2560", 0 },
@@ -885,7 +881,7 @@ static struct i2c_driver tsl2563_i2c_driver = { 
	.driver = {

		.name	 = "tsl2563",

		.of_match_table = tsl2563_of_match,

		.pm	= TSL2563_PM_OPS,

		.pm	= pm_sleep_ptr(&tsl2563_pm_ops),

	},

	.probe		= tsl2563_probe,

	.remove		= tsl2563_remove,