Commit 54edb876 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio:light:tcs3472: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc 



Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of #ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-27-jic23@kernel.org
parent f3ba0534

drivers/iio/light/tcs3472.c

+3 −4
Original line number Diff line number Diff line
@@ -572,7 +572,6 @@ static int tcs3472_remove(struct i2c_client *client) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int tcs3472_suspend(struct device *dev)

{

	struct tcs3472_data *data = iio_priv(i2c_get_clientdata(
@@ -598,9 +597,9 @@ static int tcs3472_resume(struct device *dev) 


	return ret;

}

#endif



static SIMPLE_DEV_PM_OPS(tcs3472_pm_ops, tcs3472_suspend, tcs3472_resume);

static DEFINE_SIMPLE_DEV_PM_OPS(tcs3472_pm_ops, tcs3472_suspend,

				tcs3472_resume);



static const struct i2c_device_id tcs3472_id[] = {

	{ "tcs3472", 0 },
@@ -611,7 +610,7 @@ MODULE_DEVICE_TABLE(i2c, tcs3472_id); 
static struct i2c_driver tcs3472_driver = {

	.driver = {

		.name	= TCS3472_DRV_NAME,

		.pm	= &tcs3472_pm_ops,

		.pm	= pm_sleep_ptr(&tcs3472_pm_ops),

	},

	.probe		= tcs3472_probe,

	.remove		= tcs3472_remove,