Commit 84c610ba authored by Vinod Koul's avatar Vinod Koul
Browse files

dmaengine: nbpfaxi: explicitly freeup irq 



dmaengine device should explicitly call devm_free_irq() when using
devm_request_irq().

The irq is still ON when devices remove is executed and irq should be
quiesced before remove is completed.

Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
parent 144fa37f

drivers/dma/nbpfaxi.c

+11 −0
Original line number Diff line number Diff line
@@ -227,6 +227,7 @@ struct nbpf_device { 
	void __iomem *base;

	struct clk *clk;

	const struct nbpf_config *config;

	unsigned int eirq;

	struct nbpf_channel chan[];

};
@@ -1375,6 +1376,7 @@ static int nbpf_probe(struct platform_device *pdev) 
			       IRQF_SHARED, "dma error", nbpf);

	if (ret < 0)

		return ret;

	nbpf->eirq = eirq;



	INIT_LIST_HEAD(&dma_dev->channels);
@@ -1446,6 +1448,15 @@ static int nbpf_probe(struct platform_device *pdev) 
static int nbpf_remove(struct platform_device *pdev)

{

	struct nbpf_device *nbpf = platform_get_drvdata(pdev);

	int i;



	devm_free_irq(&pdev->dev, nbpf->eirq, nbpf);



	for (i = 0; i < nbpf->config->num_channels; i++) {

		struct nbpf_channel *chan = nbpf->chan + i;



		devm_free_irq(&pdev->dev, chan->irq, chan);

	}



	of_dma_controller_free(pdev->dev.of_node);

	dma_async_device_unregister(&nbpf->dma_dev);