Commit 144fa37f authored by Vinod Koul's avatar Vinod Koul
Browse files

dmaengine: moxart-dma: explicitly freeup irq 



dmaengine device should explicitly call devm_free_irq() when using
devm_request_irq().

The irq is still ON when devices remove is executed and irq should be
quiesced before remove is completed.

Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Cc: Jonas Jensen <jonas.jensen@gmail.com>
parent 0422e304

drivers/dma/moxart-dma.c

+4 −0
Original line number Diff line number Diff line
@@ -148,6 +148,7 @@ struct moxart_chan { 
struct moxart_dmadev {

	struct dma_device		dma_slave;

	struct moxart_chan		slave_chans[APB_DMA_MAX_CHANNEL];

	unsigned int			irq;

};



struct moxart_filter_data {
@@ -615,6 +616,7 @@ static int moxart_probe(struct platform_device *pdev) 
		dev_err(dev, "devm_request_irq failed\n");

		return ret;

	}

	mdc->irq = irq;



	ret = dma_async_device_register(&mdc->dma_slave);

	if (ret) {
@@ -638,6 +640,8 @@ static int moxart_remove(struct platform_device *pdev) 
{

	struct moxart_dmadev *m = platform_get_drvdata(pdev);



	devm_free_irq(&pdev->dev, m->irq, m);



	dma_async_device_unregister(&m->dma_slave);



	if (pdev->dev.of_node)