Commit f3ba0534 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio:light:tcs3414: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc 



Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of #ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-26-jic23@kernel.org
parent 20cadda3

drivers/iio/light/tcs3414.c

+3 −4
Original line number Diff line number Diff line
@@ -345,7 +345,6 @@ static int tcs3414_probe(struct i2c_client *client, 
	return devm_iio_device_register(&client->dev, indio_dev);

}



#ifdef CONFIG_PM_SLEEP

static int tcs3414_suspend(struct device *dev)

{

	struct tcs3414_data *data = iio_priv(i2c_get_clientdata(
@@ -360,9 +359,9 @@ static int tcs3414_resume(struct device *dev) 
	return i2c_smbus_write_byte_data(data->client, TCS3414_CONTROL,

		data->control);

}

#endif



static SIMPLE_DEV_PM_OPS(tcs3414_pm_ops, tcs3414_suspend, tcs3414_resume);

static DEFINE_SIMPLE_DEV_PM_OPS(tcs3414_pm_ops, tcs3414_suspend,

				tcs3414_resume);



static const struct i2c_device_id tcs3414_id[] = {

	{ "tcs3414", 0 },
@@ -373,7 +372,7 @@ MODULE_DEVICE_TABLE(i2c, tcs3414_id); 
static struct i2c_driver tcs3414_driver = {

	.driver = {

		.name	= TCS3414_DRV_NAME,

		.pm	= &tcs3414_pm_ops,

		.pm	= pm_sleep_ptr(&tcs3414_pm_ops),

	},

	.probe		= tcs3414_probe,

	.id_table	= tcs3414_id,