Commit 50182ed4 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/nvidiafb: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-25-tzimmermann@suse.de
parent eb9d5c19

drivers/video/fbdev/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -689,10 +689,10 @@ config FB_NVIDIA 
	tristate "nVidia Framebuffer Support"

	depends on FB && PCI

	select FB_BACKLIGHT if FB_NVIDIA_BACKLIGHT

	select FB_MODE_HELPERS

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_FOPS

	select BITREVERSE

	select VGASTATE

	select VIDEO_NOMODESET

drivers/video/fbdev/nvidia/nvidia.c

+2 −0
Original line number Diff line number Diff line
@@ -1028,6 +1028,7 @@ static struct fb_ops nvidia_fb_ops = { 
	.owner          = THIS_MODULE,

	.fb_open        = nvidiafb_open,

	.fb_release     = nvidiafb_release,

	__FB_DEFAULT_IOMEM_OPS_RDWR,

	.fb_check_var   = nvidiafb_check_var,

	.fb_set_par     = nvidiafb_set_par,

	.fb_setcolreg   = nvidiafb_setcolreg,
@@ -1038,6 +1039,7 @@ static struct fb_ops nvidia_fb_ops = { 
	.fb_imageblit   = nvidiafb_imageblit,

	.fb_cursor      = nvidiafb_cursor,

	.fb_sync        = nvidiafb_sync,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



static int nvidiafb_suspend_late(struct device *dev, pm_message_t mesg)