Commit eb9d5c19 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/neofb: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-24-tzimmermann@suse.de
parent dc9c80b0

drivers/video/fbdev/Kconfig

+2 −1
Original line number Diff line number Diff line
@@ -1268,10 +1268,11 @@ endif 
config FB_NEOMAGIC

	tristate "NeoMagic display support"

	depends on FB && PCI

	select FB_MODE_HELPERS

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_FOPS

	select FB_MODE_HELPERS

	select VGASTATE

	select VIDEO_NOMODESET

	help

drivers/video/fbdev/neofb.c

+2 −0
Original line number Diff line number Diff line
@@ -1614,6 +1614,7 @@ static const struct fb_ops neofb_ops = { 
	.owner		= THIS_MODULE,

	.fb_open	= neofb_open,

	.fb_release	= neofb_release,

	__FB_DEFAULT_IOMEM_OPS_RDWR,

	.fb_check_var	= neofb_check_var,

	.fb_set_par	= neofb_set_par,

	.fb_setcolreg	= neofb_setcolreg,
@@ -1623,6 +1624,7 @@ static const struct fb_ops neofb_ops = { 
	.fb_fillrect	= neofb_fillrect,

	.fb_copyarea	= neofb_copyarea,

	.fb_imageblit	= neofb_imageblit,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



/* --------------------------------------------------------------------- */