Commit 3064ef2e authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bjorn Helgaas
Browse files

PCI: kirin: Don't discard .remove() callback 

With CONFIG_PCIE_KIRIN=y and kirin_pcie_remove() marked with __exit, the
function is discarded from the driver. In this case a bound device can
still get unbound, e.g via sysfs. Then no cleanup code is run resulting in
resource leaks or worse.

The right thing to do is do always have the remove callback available.
This fixes the following warning by modpost:

  drivers/pci/controller/dwc/pcie-kirin: section mismatch in reference: kirin_pcie_driver+0x8 (section: .data) -> kirin_pcie_remove (section: .exit.text)

(with ARCH=x86_64 W=1 allmodconfig).

Fixes: 000f60db ("PCI: kirin: Add support for a PHY layer")
Link: https://lore.kernel.org/r/20231001170254.2506508-3-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org
parent 83a939f0

drivers/pci/controller/dwc/pcie-kirin.c

+2 −2
Original line number Diff line number Diff line
@@ -741,7 +741,7 @@ static int kirin_pcie_power_on(struct platform_device *pdev, 
	return ret;

}



static int __exit kirin_pcie_remove(struct platform_device *pdev)

static int kirin_pcie_remove(struct platform_device *pdev)

{

	struct kirin_pcie *kirin_pcie = platform_get_drvdata(pdev);
@@ -818,7 +818,7 @@ static int kirin_pcie_probe(struct platform_device *pdev) 


static struct platform_driver kirin_pcie_driver = {

	.probe			= kirin_pcie_probe,

	.remove	        	= __exit_p(kirin_pcie_remove),

	.remove	        	= kirin_pcie_remove,

	.driver			= {

		.name			= "kirin-pcie",

		.of_match_table		= kirin_pcie_match,