Commit 83a939f0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bjorn Helgaas
Browse files

PCI: exynos: Don't discard .remove() callback 

With CONFIG_PCI_EXYNOS=y and exynos_pcie_remove() marked with __exit, the
function is discarded from the driver. In this case a bound device can
still get unbound, e.g via sysfs. Then no cleanup code is run resulting in
resource leaks or worse.

The right thing to do is do always have the remove callback available.
This fixes the following warning by modpost:

  WARNING: modpost: drivers/pci/controller/dwc/pci-exynos: section mismatch in reference: exynos_pcie_driver+0x8 (section: .data) -> exynos_pcie_remove (section: .exit.text)

(with ARCH=x86_64 W=1 allmodconfig).

Fixes: 340cba60 ("pci: Add PCIe driver for Samsung Exynos")
Link: https://lore.kernel.org/r/20231001170254.2506508-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarAlim Akhtar <alim.akhtar@samsung.com>
Cc: stable@vger.kernel.org
parent 8624ebc3

drivers/pci/controller/dwc/pci-exynos.c

+2 −2
Original line number Diff line number Diff line
@@ -375,7 +375,7 @@ static int exynos_pcie_probe(struct platform_device *pdev) 
	return ret;

}



static int __exit exynos_pcie_remove(struct platform_device *pdev)

static int exynos_pcie_remove(struct platform_device *pdev)

{

	struct exynos_pcie *ep = platform_get_drvdata(pdev);
@@ -431,7 +431,7 @@ static const struct of_device_id exynos_pcie_of_match[] = { 


static struct platform_driver exynos_pcie_driver = {

	.probe		= exynos_pcie_probe,

	.remove		= __exit_p(exynos_pcie_remove),

	.remove		= exynos_pcie_remove,

	.driver = {

		.name	= "exynos-pcie",

		.of_match_table = exynos_pcie_of_match,