Commit 2462bca0 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: sh: Drop superfluous PCM preallocation error checks 



snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c0256722

sound/sh/aica.c

+6 −8
Original line number Diff line number Diff line
@@ -464,14 +464,12 @@ static int __init snd_aicapcmchip(struct snd_card_aica 
	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK,

			&snd_aicapcm_playback_ops);

	/* Allocate the DMA buffers */

	err =

	snd_pcm_lib_preallocate_pages_for_all(pcm,

					      SNDRV_DMA_TYPE_CONTINUOUS,

						  snd_dma_continuous_data

						  (GFP_KERNEL),

					      snd_dma_continuous_data(GFP_KERNEL),

					      AICA_BUFFER_SIZE,

					      AICA_BUFFER_SIZE);

	return err;

	return 0;

}



/* Mixer controls */