Commit c0256722 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ppc: Drop superfluous PCM preallocation error checks 



snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5116b94a

sound/ppc/snd_ps3.c

+1 −5
Original line number Diff line number Diff line
@@ -1024,15 +1024,11 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev) 


	the_card.pcm->info_flags = SNDRV_PCM_INFO_NONINTERLEAVED;

	/* pre-alloc PCM DMA buffer*/

	ret = snd_pcm_lib_preallocate_pages_for_all(the_card.pcm,

	snd_pcm_lib_preallocate_pages_for_all(the_card.pcm,

					SNDRV_DMA_TYPE_DEV,

					&dev->core,

					SND_PS3_PCM_PREALLOC_SIZE,

					SND_PS3_PCM_PREALLOC_SIZE);

	if (ret < 0) {

		pr_info("%s: prealloc failed\n", __func__);

		goto clean_card;

	}



	/*

	 * allocate null buffer