Commit 19611aec authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio: accel: kxcjk-1013: Balance runtime pm + use pm_runtime_resume_and_get() 



This driver alls pm_runtime_put_noidle() in it's remove function, but there
is no matching get call.  This isn't a bug as runtime pm will not allow
the reference counter to go negative, but it is missleading so lets remove
it.

Whilst here use pm_runtime_resume_and_get() to tidy up some boilerplate.
The coccicheck script didn't get this one due to the less obvious
structure. Found by inspection.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/20210509113354.660190-8-jic23@kernel.org
parent 2d980d7e

drivers/iio/accel/kxcjk-1013.c

+1 −4
Original line number Diff line number Diff line
@@ -601,7 +601,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) 
	int ret;



	if (on)

		ret = pm_runtime_get_sync(&data->client->dev);

		ret = pm_runtime_resume_and_get(&data->client->dev);

	else {

		pm_runtime_mark_last_busy(&data->client->dev);

		ret = pm_runtime_put_autosuspend(&data->client->dev);
@@ -609,8 +609,6 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) 
	if (ret < 0) {

		dev_err(&data->client->dev,

			"Failed: %s for %d\n", __func__, on);

		if (on)

			pm_runtime_put_noidle(&data->client->dev);

		return ret;

	}

#endif
@@ -1616,7 +1614,6 @@ static int kxcjk1013_remove(struct i2c_client *client) 


	pm_runtime_disable(&client->dev);

	pm_runtime_set_suspended(&client->dev);

	pm_runtime_put_noidle(&client->dev);



	if (data->dready_trig) {

		iio_triggered_buffer_cleanup(indio_dev);