Commit 2d980d7e authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio: accel: mma9551/3: Balance untime pm + use pm_runtime_resume_and_get() 



Both these drivers call pm_runtime_put_no_idle() when the reference
count should already be zero as there is no matching get()

Whilst here use pm_runtime_resume_and_get() rather than open coding.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/20210509113354.660190-7-jic23@kernel.org
parent d3a8969d

drivers/iio/accel/mma9551.c

+0 −1
Original line number Diff line number Diff line
@@ -515,7 +515,6 @@ static int mma9551_remove(struct i2c_client *client) 


	pm_runtime_disable(&client->dev);

	pm_runtime_set_suspended(&client->dev);

	pm_runtime_put_noidle(&client->dev);



	mutex_lock(&data->mutex);

	mma9551_set_device_state(data->client, false);

drivers/iio/accel/mma9551_core.c

+1 −3
Original line number Diff line number Diff line
@@ -664,7 +664,7 @@ int mma9551_set_power_state(struct i2c_client *client, bool on) 
	int ret;



	if (on)

		ret = pm_runtime_get_sync(&client->dev);

		ret = pm_runtime_resume_and_get(&client->dev);

	else {

		pm_runtime_mark_last_busy(&client->dev);

		ret = pm_runtime_put_autosuspend(&client->dev);
@@ -673,8 +673,6 @@ int mma9551_set_power_state(struct i2c_client *client, bool on) 
	if (ret < 0) {

		dev_err(&client->dev,

			"failed to change power state to %d\n", on);

		if (on)

			pm_runtime_put_noidle(&client->dev);



		return ret;

	}

drivers/iio/accel/mma9553.c

+0 −1
Original line number Diff line number Diff line
@@ -1154,7 +1154,6 @@ static int mma9553_remove(struct i2c_client *client) 


	pm_runtime_disable(&client->dev);

	pm_runtime_set_suspended(&client->dev);

	pm_runtime_put_noidle(&client->dev);



	mutex_lock(&data->mutex);

	mma9551_set_device_state(data->client, false);