Commit 12b31d07 authored by Gaston Gonzalez's avatar Gaston Gonzalez Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: update TODO file 



There are no struct typedef remaining inside vc04_services/. Hence, remove the
task from the TODO file.

While at it, fix the items sequential numbering.

Signed-off-by: default avatarGaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 072590cc

drivers/staging/vc04_services/interface/TODO

+2 −6
Original line number Diff line number Diff line
@@ -80,11 +80,7 @@ vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process. 


The code in vchiq_bcm2835_arm.c should fit in the generic platform file.



12) Get rid of all the struct typedefs



Most structs are typedefd, it's not encouraged in the kernel.



13) Get rid of all non essential global structures and create a proper per

11) Get rid of all non essential global structures and create a proper per

device structure



The first thing one generally sees in a probe function is a memory allocation
@@ -92,6 +88,6 @@ for all the device specific data. This structure is then passed all over the 
driver. This is good practice since it makes the driver work regardless of the

number of devices probed.



14) Clean up Sparse warnings from __user annotations. See

12) Clean up Sparse warnings from __user annotations. See

vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter"

is never disclosed to userspace.