Commit 072590cc authored by Gaston Gonzalez's avatar Gaston Gonzalez Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers 



Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to
better align with the linux kernel coding style.

Signed-off-by: default avatarGaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 95b47a04

drivers/staging/vc04_services/bcm2835-camera/controls.c

+2 −8
Original line number Diff line number Diff line
@@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { 
	MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */

};



struct bm2835_mmal_v4l2_ctrl;



typedef	int(bm2835_mmal_v4l2_ctrl_cb)(

				struct bm2835_mmal_dev *dev,

				struct v4l2_ctrl *ctrl,

				const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);



struct bm2835_mmal_v4l2_ctrl {

	u32 id; /* v4l2 control identifier */

	enum bm2835_mmal_ctrl_type type;
@@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { 
	u64 step; /* step size of the control */

	const s64 *imenu; /* integer menu array */

	u32 mmal_id; /* mmal parameter id */

	bm2835_mmal_v4l2_ctrl_cb *setter;

	int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl,

		      const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);

};



struct v4l2_to_mmal_effects_setting {