1. Nov 17, 2023
  2. Jul 28, 2023
  3. Jun 15, 2023
    • Vitaly Chikunov's avatar
      Fix gcc13 error: writing 1 byte into a region of size 0 · af20283d
      Vitaly Chikunov authored
      gcc-13 thinks `bl` can take negative value (when returned from
      EVP_CIPHER_CTX_block_size). Do simple sanity checking to workaround this.
      Also, add error propagation up to EVP_DigestFinal_ex, so this sanity checking
      is not in vain.
      
      Error message:
      
        In function 'make_kn',
            inlined from 'CMAC_ACPKM_Final' at /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:274:5,
            inlined from 'omac_acpkm_imit_final' at /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:354:5:
        /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:55:20: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
           55 |         k1[bl - 1] ^= bl == 16 ? 0x87 : 0x1b;
              |         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
        /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c: In function 'omac_acpkm_imit_final':
        /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:260:24: note: at offset [-2147483649, -1] into destination object 'k2' of size 32
          260 |     unsigned char *k1, k2[EVP_MAX_BLOCK_LENGTH];
              |                        ^~
      
      Fixes: https://github.com/gost-engine/engine/issues/436
      
      
      Signed-off-by: default avatarVitaly Chikunov <vt@altlinux.org>
      af20283d
  4. Jan 06, 2023
    • Craig Andrews's avatar
      Correct CMake files installation path · 2b22503c
      Craig Andrews authored
      install(EXPORT GostEngineConfig DESTINATION share/cmake/GostEngine) will to a path like this:
      /usr/GostEngine/share/cmake/GostEngine/GostEngineConfig.cmake
      which is not standard or expected. These files should be installed to:
      /usr/share/cmake/GostEngine/GostEngineConfig.cmake
      which can be done by changing the installation line to:
      install(EXPORT GostEngineConfig DESTINATION share/cmake/GostEngine)
      2b22503c
  5. Dec 03, 2022
  6. Nov 03, 2022
  7. Sep 25, 2022
  8. Aug 11, 2022
  9. Jul 22, 2022
  10. Jul 11, 2022
  11. Jul 02, 2022
  12. May 25, 2022
  13. May 23, 2022
  14. May 05, 2022
  15. Feb 08, 2022
  16. Feb 06, 2022
  17. Jan 10, 2022
    • Vitaly Chikunov's avatar
      gost_prov: OPENSSL_free what is OPENSSL_zalloc'd · da0c648b
      Vitaly Chikunov authored
      
      
        *** CID 345254:  API usage errors  (ALLOC_FREE_MISMATCH)
        /gost_prov.c: 71 in provider_ctx_new()
        65             && populate_gost_engine(ctx->e)) {
        66             ctx->core_handle = core;
        67
        68             /* Ugly hack */
        69             err_handle = ctx->proverr_handle;
        70         } else {
        >>>     CID 345254:  API usage errors  (ALLOC_FREE_MISMATCH)
        >>>     Calling "provider_ctx_free" frees "ctx" using "free" but it should have been freed using "CRYPTO_free".
        71             provider_ctx_free(ctx);
        72             ctx = NULL;
        73         }
        74         return ctx;
        75     }
      
      Fixes: f5a3951 ("gost_prov: Avoid access to unallocated memory")
      Signed-off-by: default avatarVitaly Chikunov <vt@altlinux.org>
      da0c648b
  18. Jan 09, 2022
    • Vitaly Chikunov's avatar
      gost_prov: Avoid access to unallocated memory · eea1e27c
      Vitaly Chikunov authored
      
      
      This should fix Coverity warning:
      
        *** CID 345245:    (UNINIT)
        /gost_prov.c: 71 in provider_ctx_new()
        65             && populate_gost_engine(ctx->e)) {
        66             ctx->core_handle = core;
        67
        68             /* Ugly hack */
        69             err_handle = ctx->proverr_handle;
        70         } else {
        >>>     CID 345245:    (UNINIT)
        >>>     Using uninitialized value "ctx->e" when calling "provider_ctx_free".
        71             provider_ctx_free(ctx);
        72             ctx = NULL;
        73         }
        74         return ctx;
        75     }
      
      Signed-off-by: default avatarVitaly Chikunov <vt@altlinux.org>
      Issue: #380
      eea1e27c
    • Vitaly Chikunov's avatar
      gost_ec_keyx: Check CTX data before it's really used · 5dc8f91c
      Vitaly Chikunov authored
      
      
      This should fix Coverity warning:
      
        *** CID 345243:  Null pointer dereferences  (REVERSE_INULL)
        /gost_ec_keyx.c: 681 in pkey_gost2018_decrypt()
        675        o  Q_eph is on the same curve as server public key;
        676
        677        o  Q_eph is not equal to zero point;
        678
        679        o  q * Q_eph is not equal to zero point.
        680     */
        >>>     CID 345243:  Null pointer dereferences  (REVERSE_INULL)
        >>>     Null-checking "data" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
        681         if (eph_key == NULL || priv == NULL || data == NULL) {
        682            GOSTerr(GOST_F_PKEY_GOST2018_DECRYPT,
        683                    GOST_R_ERROR_COMPUTING_EXPORT_KEYS);
        684            ret = 0;
        685            goto err;
        686         }
      
      Signed-off-by: default avatarVitaly Chikunov <vt@altlinux.org>
      Issue: #380
      5dc8f91c
  19. Jan 08, 2022
  20. Jan 07, 2022
  21. Dec 21, 2021
  22. Dec 20, 2021
  23. Dec 15, 2021
  24. Dec 12, 2021