Unverified Commit fdfea6b3 authored by mergify[bot]'s avatar mergify[bot] Committed by GitHub
Browse files

Don't Dedup modules if it would change semantics (bp #1713) (#1714)

* Don't Dedup modules if it would change semantics (#1713)

If a module has ports of type Bundle that are used in aggregate
connections in parent modules, Dedup cannot change the names of the
fields of the Bundle or it would change the semantics of the connection.
Dedup now detects this case and refrains from agnostifying the ports of
such modules to prevent this issue.

(cherry picked from commit e0e68568

)

# Conflicts:
#	src/main/scala/firrtl/transforms/Dedup.scala
#	src/test/scala/firrtlTests/transforms/DedupTests.scala

* Fixup for 1.2.x

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
parent 252fa3f7
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment