1. Jun 27, 2017
    • Richard Lin's avatar
      Directions internals mega-refactor (#617) · aaee58d3
      Richard Lin authored
      Part 1 of mega-change in #578
      
      Major notes:
      - Input(...) and Output(...) now (effectively) recursively override their elements' directions
      - Nodes given userDirection (Input, Output, Flip - what the user assigned to _that_ node) and actualDirection (Input, Output, None, but also Bidirectional and BidirectionalFlip for mostly Aggregates), because of the above (since a higher-level Input(...) can override the locally specified user direction).
      - DataMirror (node reflection APIs) added to chisel3.experimental. This provides ways to query the user given direction of a node as well as the actual direction.
      - checkSynthesizable replaced with requireIsHardware and requireIsChiselType and made available in chisel3.experimental.
      
      Internal changes notes:
      - toType moved into Emitter, this makes the implementation cleaner especially considering that Vec types can't be flipped in FIRRTL. This also more clearly separates Chisel frontend from FIRRTL emission.
      - Direction separated from Bindings, both are now fields in Data, and all nodes are given hierarchical directions (Aggregates may be Bidirectional). The actualDirection at the Element (leaf) level should be the same as binding directions previously.
      - Bindings are hierarchical, children (of a, for example, Bundle) have a ChildBinding that points to their parent. This is different than the previous scheme where Bindings only applied at the Element (leaf) level.
      - Lots of small misc clean up.
      
      Future PRs will address other parts of #578, including stricter direction checks that aren't a side-effect of this internal refactor, stricter checks and splitting of binding operations (Wire vs. WireInit), and node operations not introduced here (getType and deprecation of chiselCloneType). Since those shouldn't mess with internals, those should be much smaller.
      aaee58d3
  2. Jun 20, 2017
  3. Jun 01, 2017
  4. May 29, 2017
  5. May 26, 2017
  6. May 20, 2017
    • Jim Lawson's avatar
      Update comments describing Decoupled/ReadyValid - fix #437. (#493) · cb28230d
      Jim Lawson authored
      * Update comments describing Decoupled/ReadyValid.
      It seems there is a valid use case for EnqIO/DeqIO and updating the comments may clear some of the confusion and encourage their usage.
      
      * Update comments - no functional changes.
      Re-flow comments for ReadyValidIO()
      Add gen param to DecoupledIO() and IrrevocableIO().
      
      * Update code and comment now that #492 is resolved
      cb28230d
  7. May 13, 2017
  8. May 12, 2017
  9. May 11, 2017
    • Jack Koenig's avatar
      Add implicit CompileOptions to Record and Bundle (#595) · 45e235a5
      Jack Koenig authored
      Fixes #495
      
      Helps distinguish between Records/Bundles defined in Chisel._ vs.
      chisel3._. Also override compilationOptions when bulk connecting
      Records/Bundles defined in Chisel._. This allows Records/Bundles defined
      in Chisel._ code to be correctly bulk connected in chisel3._ code.
      45e235a5
  10. May 05, 2017
  11. May 04, 2017
  12. Apr 28, 2017
  13. Apr 27, 2017
    • Richard Lin's avatar
      36718cf6
    • Jim Lawson's avatar
      Dropimportnotstrict492 - More updates to get things through rocket-chip. (#592) · 7449fdc9
      Jim Lawson authored
      * Remove explicit import of NotStrict - fixes #492
      
      * Provide macro for MemBase.apply().
      
      * Provide macro for MemBase.apply().
      Since a macro cannot override an abstract method, provide a concrete
      apply method n VecLike() that we can override with a macro.
      
      * Remove concrete apply() in VecLike.
      Since MemBase no longer extends the trait VecLike, we do not require a concrete method to which we can apply a macro to extract the appropriate CompileOptions.
      
      * Add missing implicit compileOptions to do_pad() and do_zext().
      The latter caused:
      ```
      [error] /vm/home/jenkins/workspace/rocket-chip_with_chisel3/hardfloat/src/main/scala/MulAddRecFN.scala:205: too many arguments for method do_zext: (implicit sourceInfo: chisel3.internal.sourceinfo.SourceInfo)chisel3.core.SInt
      [error]     val CDom_sExp = io.fromPreMul.sExpSum - io.fromPreMul.doSubMags.zext
      ```
      
      * Add SourceInfoTransform macros to Vec methods in order to avoid apply() chain issues.
      Since utils methods are no longer NotStrict, Pipe objects need access to the client's compile options. There may be more.
      
      * Respond to review comments.
      Don't propagate SourceInfo through helper functions.
      Replace old usages of CompileOptionsTransform with the now equivalent SourceInfoTransform and redefine CompileOptionsTransform to only deal with CompileOptions.
      Just thread CompileOptions (not SourceInfo) through deprecated functions.
      7449fdc9
  14. Apr 25, 2017
    • Jim Lawson's avatar
      Remove explicit import of NotStrict - fixes #492 (#494) · 4a6396ca
      Jim Lawson authored
      * Remove explicit import of NotStrict - fixes #492
      
      * Provide macro for MemBase.apply().
      
      * Provide macro for MemBase.apply().
      Since a macro cannot override an abstract method, provide a concrete
      apply method n VecLike() that we can override with a macro.
      
      * Remove concrete apply() in VecLike.
      Since MemBase no longer extends the trait VecLike, we do not require a concrete method to which we can apply a macro to extract the appropriate CompileOptions.
      4a6396ca
  15. Apr 22, 2017
  16. Apr 15, 2017
  17. Apr 14, 2017
  18. Apr 13, 2017
    • Chick Markley's avatar
      Fix one hot mux (#573) · 97902cdc
      Chick Markley authored
      * still trying to find right mix
      
      * Making some progress on Mux1H
      
      * Mux1H that works in non-optimzed fashion for FixedPoint, works pretty well in general
      Catches some additional problem edge cases
      Some tests that illustrate most of this
      
      * Moved in Angie's code for handling FixedPoint case
      Cleaned up tests considerably, per @ducky64 review
      
      * Just a bit more cleanup
      97902cdc
  19. Apr 08, 2017
  20. Apr 05, 2017
  21. Apr 03, 2017
  22. Mar 28, 2017
  23. Mar 25, 2017
  24. Mar 18, 2017
  25. Mar 14, 2017
    • Jim Lawson's avatar
      Revert "Change Vec creation to check if gen is lit (and hence needs t… (#530) · a6798adb
      Jim Lawson authored
      * Revert "Change Vec creation to check if gen is lit (and hence needs to be declared)"
      
      This reverts commit dc86e7e1734d6abacb739b488df1de231e6b41b2.
      This may address #522 - using chiselCloneType (instead of cloneType) to preserve directionality.
      
      * Add missing implicits to Vec.apply() signature.
      
      * Use correct macro (CompileOptionsTransform) for indexWhere.
      a6798adb
  26. Mar 09, 2017