Tests, ehancements and bug fixes for exec

Add Tcl tests for exec
Fix some errors exposed by these tests
Add support for >&, >>&, |&

1 files changed, 475 insertions, 0 deletions

diff --git a/tests/exec.test b/tests/exec.test
new file mode 100644
index 0000000..f37b5fb
--- /dev/null
+++ b/tests/exec.test
@@ -0,0 +1,475 @@
+# Commands covered:  exec
+#
+# This file contains a collection of tests for one or more of the Tcl
+# built-in commands.  Sourcing this file into Tcl runs the tests and
+# generates output for errors.  No output means no errors were found.
+#
+# Copyright (c) 1991-1994 The Regents of the University of California.
+# Copyright (c) 1994-1997 Sun Microsystems, Inc.
+# Copyright (c) 1998-1999 by Scriptics Corporation.
+#
+# See the file "license.terms" for information on usage and redistribution
+# of this file, and for a DISCLAIMER OF ALL WARRANTIES.
+#
+# RCS: @(#) $Id: exec.test,v 1.8.2.1 2001/10/17 19:29:25 das Exp $
+
+source testing.tcl
+
+set f [open echo w]
+puts $f {
+    puts -nonewline [lindex $argv 0]
+    foreach str [lrange $argv 1 end] {
+	puts -nonewline " $str"
+    }
+    puts {}
+    exit
+}
+close $f
+
+set f [open cat w]
+puts $f {
+    if {$argv == {}} {
+	set argv -
+    }
+    foreach name $argv {
+	if {$name == "-"} {
+	    set f stdin
+	} elseif {[catch {open $name r} f] != 0} {
+	    puts stderr $f
+	    continue
+	}
+	while {[eof $f] == 0} {
+	    puts -nonewline [read $f]
+	}
+	if {$f != "stdin"} {
+	    close $f
+	}
+    }
+    exit
+}
+close $f
+
+set f [open wc w]
+puts $f {
+    set data [read stdin]
+    set lines [regsub -all "\n" $data {} dummy]
+    set words [regsub -all "\[^ \t\n]+" $data {} dummy]
+    set chars [string length $data]
+    puts [format "%8.d%8.d%8.d" $lines $words $chars]
+    exit
+}
+close $f
+
+set f [open sh w]
+puts $f {
+    if {[lindex $argv 0] != "-c"} {
+	error "sh: unexpected arguments $argv"
+    }
+    set cmd [lindex $argv 1]
+    lappend cmd ";"
+
+    set newcmd {}
+    
+    foreach arg $cmd {
+	if {$arg == ";"} {
+	    eval exec >@stdout 2>@stderr [list [info nameofexecutable]] $newcmd
+	    set newcmd {}
+	    continue
+	}
+	if {$arg == "1>&2"} {
+	    set arg >@stderr
+	}
+	lappend newcmd $arg
+    }
+    exit
+}
+close $f
+
+set f [open sleep w]
+puts $f {
+    after [expr $argv*1000]
+    exit
+}
+close $f
+
+set f [open exit w]
+puts $f {
+    exit $argv
+}
+close $f
+
+# Basic operations.
+
+test exec-1.1 {basic exec operation} {
+    exec echo a b c
+} "a b c"
+test exec-1.2 {pipelining} {
+    exec echo a b c d | cat | cat
+} "a b c d"
+test exec-1.3 {pipelining} {
+    set a [exec echo a b c d | cat | wc]
+    list [scan $a "%d %d %d" b c d] $b $c
+} {3 1 4}
+set arg {12345678901234567890123456789012345678901234567890}
+set arg "$arg$arg$arg$arg$arg$arg"
+test exec-1.4 {long command lines} {
+    exec echo $arg
+} $arg
+set arg {}
+
+# I/O redirection: input from Tcl command.
+
+test exec-2.1 {redirecting input from immediate source} {
+    exec cat << "Sample text"
+} {Sample text}
+test exec-2.2 {redirecting input from immediate source} {
+    exec << "Sample text" cat | cat
+} {Sample text}
+test exec-2.3 {redirecting input from immediate source} {
+    exec cat << "Sample text" | cat
+} {Sample text}
+test exec-2.4 {redirecting input from immediate source} {
+    exec cat | cat << "Sample text"
+} {Sample text}
+test exec-2.5 {redirecting input from immediate source} {
+    exec cat "<<Joined to arrows"
+} {Joined to arrows}
+test exec-2.6 {redirecting input from immediate source, with UTF} {
+    # If this fails, it may give back:
+    # "\uC3\uA9\uC3\uA0\uC3\uBC\uC3\uB1"
+    # If it does, this means that the UTF -> external conversion did not 
+    # occur before writing out the temp file.
+    exec cat << "\uE9\uE0\uFC\uF1"
+} "\uE9\uE0\uFC\uF1"
+
+# I/O redirection: output to file.
+
+file delete gorp.file
+test exec-3.1 {redirecting output to file} {
+    exec echo "Some simple words" > gorp.file
+    exec cat gorp.file
+} "Some simple words"
+test exec-3.2 {redirecting output to file} {
+    exec echo "More simple words" | >gorp.file cat | cat
+    exec cat gorp.file
+} "More simple words"
+test exec-3.3 {redirecting output to file} {
+    exec > gorp.file echo "Different simple words" | cat | cat
+    exec cat gorp.file
+} "Different simple words"
+test exec-3.4 {redirecting output to file} {
+    exec echo "Some simple words" >gorp.file
+    exec cat gorp.file
+} "Some simple words"
+test exec-3.5 {redirecting output to file} {
+    exec echo "First line" >gorp.file
+    exec echo "Second line" >> gorp.file
+    exec cat gorp.file
+} "First line\nSecond line"
+test exec-3.6 {redirecting output to file} {
+    exec echo "First line" >gorp.file
+    exec echo "Second line" >>gorp.file
+    exec cat gorp.file
+} "First line\nSecond line"
+test exec-3.7 {redirecting output to file} {
+    set f [open gorp.file w]
+    puts $f "Line 1"
+    flush $f
+    exec echo "More text" >@ $f
+    exec echo >@$f "Even more"
+    puts $f "Line 3"
+    close $f
+    exec cat gorp.file
+} "Line 1\nMore text\nEven more\nLine 3"
+
+# I/O redirection: output and stderr to file.
+
+file delete gorp.file
+test exec-4.1 {redirecting output and stderr to file} {
+    exec echo "test output" >& gorp.file
+    exec cat gorp.file
+} "test output"
+test exec-4.2 {redirecting output and stderr to file} {
+    list [exec sh -c "echo foo bar 1>&2" >&gorp.file] \
+	    [exec cat gorp.file]
+} {{} {foo bar}}
+test exec-4.3 {redirecting output and stderr to file} {
+    exec echo "first line" > gorp.file
+    list [exec sh -c "echo foo bar 1>&2" >>&gorp.file] \
+	    [exec cat gorp.file]
+} "{} {first line\nfoo bar}"
+test exec-4.4 {redirecting output and stderr to file} {
+    set f [open gorp.file w]
+    puts $f "Line 1"
+    flush $f
+    exec echo "More text" >&@ $f
+    exec echo >&@$f "Even more"
+    puts $f "Line 3"
+    close $f
+    exec cat gorp.file
+} "Line 1\nMore text\nEven more\nLine 3"
+test exec-4.5 {redirecting output and stderr to file} {
+    set f [open gorp.file w]
+    puts $f "Line 1"
+    flush $f
+    exec >&@ $f sh -c "echo foo bar 1>&2"
+    exec >&@$f sh -c "echo xyzzy 1>&2"
+    puts $f "Line 3"
+    close $f
+    exec cat gorp.file
+} "Line 1\nfoo bar\nxyzzy\nLine 3"
+
+# I/O redirection: input from file.
+
+exec echo "Just a few thoughts" > gorp.file
+
+test exec-5.1 {redirecting input from file} {
+    exec cat < gorp.file
+} {Just a few thoughts}
+test exec-5.2 {redirecting input from file} {
+    exec cat | cat < gorp.file
+} {Just a few thoughts}
+test exec-5.3 {redirecting input from file} {
+    exec cat < gorp.file | cat
+} {Just a few thoughts}
+test exec-5.4 {redirecting input from file} {
+    exec < gorp.file cat | cat
+} {Just a few thoughts}
+test exec-5.5 {redirecting input from file} {
+    exec cat <gorp.file
+} {Just a few thoughts}
+test exec-5.6 {redirecting input from file} {
+    set f [open gorp.file r]
+    set result [exec cat <@ $f]
+    close $f
+    set result
+} {Just a few thoughts}
+test exec-5.7 {redirecting input from file} {
+    set f [open gorp.file r]
+    set result [exec <@$f cat]
+    close $f
+    set result
+} {Just a few thoughts}
+
+# I/O redirection: standard error through a pipeline.
+
+test exec-6.1 {redirecting stderr through a pipeline} {
+    exec sh -c "echo foo bar" |& cat
+} "foo bar"
+test exec-6.2 {redirecting stderr through a pipeline} {
+    exec sh -c "echo foo bar 1>&2" |& cat
+} "foo bar"
+test exec-6.3 {redirecting stderr through a pipeline} {
+    exec sh -c "echo foo bar 1>&2" \
+	|& sh -c "echo second msg 1>&2 ; cat" |& cat
+} "second msg\nfoo bar"
+
+# I/O redirection: combinations.
+
+file delete gorp.file2
+test exec-7.1 {multiple I/O redirections} {
+    exec << "command input" > gorp.file2 cat < gorp.file
+    exec cat gorp.file2
+} {Just a few thoughts}
+test exec-7.2 {multiple I/O redirections} {
+    exec < gorp.file << "command input" cat
+} {command input}
+
+# Long input to command and output from command.
+
+set a "0123456789 xxxxxxxxx abcdefghi ABCDEFGHIJK\n"
+set a [concat $a $a $a $a]
+set a [concat $a $a $a $a]
+set a [concat $a $a $a $a]
+set a [concat $a $a $a $a]
+test exec-8.1 {long input and output} {
+    exec cat << $a
+} $a
+
+# More than 20 arguments to exec.
+
+test exec-8.1 {long input and output} {
+    exec echo 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
+} {1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23}
+
+# Commands that return errors.
+
+test exec-9.1 {commands returning errors} {
+    catch {exec gorp456}
+} {1}
+test exec-9.2 {commands returning errors} {
+    catch {exec echo foo | foo123} msg
+} {1}
+test exec-9.3 {commands returning errors} {
+    list [catch {exec sleep 1 | false | sleep 1} msg]
+} {1}
+test exec-9.4 {commands returning errors} {
+    list [catch {exec false | echo "foo bar"} msg] $msg
+} {1 {foo bar}}
+test exec-9.5 {commands returning errors} {
+    list [catch {exec gorp456 | echo a b c} msg]
+} {1}
+test exec-9.6 {commands returning errors} {
+    list [catch {exec sh -c "echo error msg 1>&2"} msg] $msg
+} {0 {error msg}}
+test exec-9.7 {commands returning errors} {
+    list [catch {exec sh -c "echo error msg 1>&2" \
+		     | sh -c "echo error msg 1>&2"} msg] $msg
+} {0 {error msg
+error msg}}
+
+# Errors in executing the Tcl command, as opposed to errors in the
+# processes that are invoked.
+
+test exec-10.1 {errors in exec invocation} {
+    list [catch {exec} msg]
+} {1}
+test exec-10.2 {errors in exec invocation} {
+    list [catch {exec | cat} msg] $msg
+} {1 {illegal use of | or |& in command}}
+test exec-10.3 {errors in exec invocation} {
+    list [catch {exec cat |} msg] $msg
+} {1 {illegal use of | or |& in command}}
+test exec-10.4 {errors in exec invocation} {
+    list [catch {exec cat | | cat} msg] $msg
+} {1 {illegal use of | or |& in command}}
+test exec-10.5 {errors in exec invocation} {
+    list [catch {exec cat | |& cat} msg] $msg
+} {1 {illegal use of | or |& in command}}
+test exec-10.6 {errors in exec invocation} {
+    list [catch {exec cat |&} msg] $msg
+} {1 {illegal use of | or |& in command}}
+test exec-10.7 {errors in exec invocation} {
+    list [catch {exec cat <} msg] $msg
+} {1 {can't specify "<" as last word in command}}
+test exec-10.8 {errors in exec invocation} {
+    list [catch {exec cat >} msg] $msg
+} {1 {can't specify ">" as last word in command}}
+test exec-10.9 {errors in exec invocation} {
+    list [catch {exec cat <<} msg] $msg
+} {1 {can't specify "<<" as last word in command}}
+test exec-10.10 {errors in exec invocation} {
+    list [catch {exec cat >>} msg] $msg
+} {1 {can't specify ">>" as last word in command}}
+test exec-10.11 {errors in exec invocation} {
+    list [catch {exec cat >&} msg] $msg
+} {1 {can't specify ">&" as last word in command}}
+test exec-10.12 {errors in exec invocation} {
+    list [catch {exec cat >>&} msg] $msg
+} {1 {can't specify ">>&" as last word in command}}
+test exec-10.13 {errors in exec invocation} {
+    list [catch {exec cat >@} msg] $msg
+} {1 {can't specify ">@" as last word in command}}
+test exec-10.14 {errors in exec invocation} {
+    list [catch {exec cat <@} msg] $msg
+} {1 {can't specify "<@" as last word in command}}
+test exec-10.15 {errors in exec invocation} {
+    list [catch {exec cat < a/b/c} msg] [string tolower $msg]
+} {1 {couldn't read file "a/b/c": no such file or directory}}
+test exec-10.16 {errors in exec invocation} {
+    list [catch {exec cat << foo > a/b/c} msg] [string tolower $msg]
+} {1 {couldn't write file "a/b/c": no such file or directory}}
+test exec-10.17 {errors in exec invocation} {
+    list [catch {exec cat << foo > a/b/c} msg] [string tolower $msg]
+} {1 {couldn't write file "a/b/c": no such file or directory}}
+set f [open gorp.file w]
+test exec-10.18 {errors in exec invocation} {
+    list [catch {exec cat <<test <@ $f} msg]
+} 1
+close $f
+set f [open gorp.file r]
+test exec-10.19 {errors in exec invocation} {
+    list [catch {exec cat <<test >@ $f} msg]
+} 1
+close $f
+
+# Commands in background.
+
+test exec-11.1 {commands in background} {
+    set x [lindex [time {exec sleep 2 &}] 0]
+    expr $x<1000000
+} 1
+test exec-11.2 {commands in background} {
+    list [catch {exec echo a &b} msg] $msg
+} {0 {a &b}}
+test exec-11.3 {commands in background} {
+    llength [exec sleep 1 &]
+} 1
+test exec-11.4 {commands in background} {
+    llength [exec sleep 1 | sleep 1 | sleep 1 &]
+} 3
+
+# Make sure that background commands are properly reaped when
+# they eventually die.
+
+exec sleep 3
+
+test exec-12.1 {reaping background processes} {
+    for {set i 0} {$i < 20} {incr i} {
+		exec echo foo > /dev/null &
+    }
+    exec sleep 1
+    catch {exec ps | fgrep "echo foo" | fgrep -v fgrep | wc} msg
+    lindex $msg 0
+} 0
+
+# Redirecting standard error separately from standard output
+
+test exec-15.1 {standard error redirection} {
+    exec echo "First line" > gorp.file
+    list [exec sh -c "echo foo bar 1>&2" 2> gorp.file] \
+	    [exec cat gorp.file]
+} {{} {foo bar}}
+test exec-15.2 {standard error redirection} {
+    list [exec sh -c "echo foo bar 1>&2" \
+		| echo biz baz >gorp.file 2> gorp.file2] \
+	    [exec cat gorp.file] \
+	    [exec cat gorp.file2]
+} {{} {biz baz} {foo bar}}
+test exec-15.3 {standard error redirection} {
+    list [exec sh -c "echo foo bar 1>&2" \
+	        | echo biz baz 2>gorp.file > gorp.file2] \
+	    [exec cat gorp.file] \
+	    [exec cat gorp.file2]
+} {{} {foo bar} {biz baz}}
+test exec-15.4 {standard error redirection} {
+    set f [open gorp.file w]
+    puts $f "Line 1"
+    flush $f
+    exec sh -c "echo foo bar 1>&2" 2>@ $f
+    puts $f "Line 3"
+    close $f
+    exec cat gorp.file
+} {Line 1
+foo bar
+Line 3}
+test exec-15.5 {standard error redirection} {
+    exec echo "First line" > gorp.file
+    exec sh -c "echo foo bar 1>&2" 2>> gorp.file
+    exec cat gorp.file
+} {First line
+foo bar}
+test exec-15.6 {standard error redirection} {
+    exec sh -c "echo foo bar 1>&2" > gorp.file2 2> gorp.file \
+	    >& gorp.file 2> gorp.file2 | echo biz baz
+    list [exec cat gorp.file] [exec cat gorp.file2]
+} {{biz baz} {foo bar}}
+
+test exec-16.1 {flush output before exec} {
+    set f [open gorp.file w]
+    puts $f "First line"
+    exec echo "Second line" >@ $f
+    puts $f "Third line"
+    close $f
+    exec cat gorp.file
+} {First line
+Second line
+Third line}
+
+# cleanup
+file delete script gorp.file gorp.file2
+file delete echo cat wc sh sleep exit
+file delete err
+
+testreport
+