diff options
| author | Steve Bennett <steveb@workware.net.au> | 2025-07-07 22:56:36 +1000 |
|---|---|---|
| committer | Steve Bennett <steveb@workware.net.au> | 2025-07-07 23:03:06 +1000 |
| commit | 5b72bde554529818ca288d54deac63dd2e428483 (patch) | |
| tree | 7af7ff60cf3a3f1ba2b23f8adf5a1e9a72afcbc5 /jim.h | |
| parent | 6c1d558d1df64683184c305250917490940a0062 (diff) | |
| download | jimtcl-master-next.zip jimtcl-master-next.tar.gz jimtcl-master-next.tar.bz2 | |
core: Jim_SetVariable() now frees value on errormaster-next
If the value has a zero reference count, free it in the error path.
Otherwise callers can't do: Jim_SetVariable(..., Jim_New...())
in case the object is leaked in the error path.
Fix various callers that were previously freeing the object in the
error path, and add a test to loop.test to show that this was not.
Signed-off-by: Steve Bennett <steveb@workware.net.au>
Diffstat (limited to 'jim.h')
| -rw-r--r-- | jim.h | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -838,6 +838,7 @@ JIM_EXPORT int Jim_RenameCommand (Jim_Interp *interp, Jim_Obj *oldNameObj, Jim_Obj *newNameObj); JIM_EXPORT Jim_Cmd * Jim_GetCommand (Jim_Interp *interp, Jim_Obj *objPtr, int flags); +/* Note that if Jim_SetVariable() fails, and valObjPtr has a zero reference count, it will be freed */ JIM_EXPORT int Jim_SetVariable (Jim_Interp *interp, Jim_Obj *nameObjPtr, Jim_Obj *valObjPtr); JIM_EXPORT int Jim_SetVariableStr (Jim_Interp *interp, |