core: Jim_SetVariable() now frees value on errormaster-next

If the value has a zero reference count, free it in the error path.
Otherwise callers can't do: Jim_SetVariable(..., Jim_New...())
in case the object is leaked in the error path.

Fix various callers that were previously freeing the object in the
error path, and add a test to loop.test to show that this was not.

Signed-off-by: Steve Bennett <steveb@workware.net.au>

1 files changed, 0 insertions, 4 deletions

diff --git a/jim-regexp.c b/jim-regexp.c
index 22e69eb..d19867e 100644
--- a/jim-regexp.c
+++ b/jim-regexp.c
@@ -308,7 +308,6 @@ int Jim_RegexpCmd(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
             result = Jim_SetVariable(interp, argv[i + 2 + j], resultObj);
 
             if (result != JIM_OK) {
-                Jim_FreeObj(interp, resultObj);
                 break;
             }
         }
@@ -618,9 +617,6 @@ cmd_error:
             if (result == JIM_OK) {
                 Jim_SetResultInt(interp, num_matches);
             }
-            else {
-                Jim_FreeObj(interp, resultObj);
-            }
         }
         else {
             Jim_SetResult(interp, resultObj);