core: Jim_SetVariable() now frees value on errormaster-next

If the value has a zero reference count, free it in the error path.
Otherwise callers can't do: Jim_SetVariable(..., Jim_New...())
in case the object is leaked in the error path.

Fix various callers that were previously freeing the object in the
error path, and add a test to loop.test to show that this was not.

Signed-off-by: Steve Bennett <steveb@workware.net.au>

1 files changed, 1 insertions, 7 deletions

diff --git a/jim-pack.c b/jim-pack.c
index e3395b6..b567cec 100644
--- a/jim-pack.c
+++ b/jim-pack.c
@@ -371,7 +371,6 @@ static int Jim_PackCmd(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
     double fvalue;
     Jim_Obj *stringObjPtr;
     int len;
-    int freeobj = 0;
 
     if (Jim_GetEnum(interp, argv[3], options, &option, NULL, JIM_ERRMSG) != JIM_OK) {
         return JIM_ERR;
@@ -406,10 +405,8 @@ static int Jim_PackCmd(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
     if (!stringObjPtr) {
         /* Create the string if it doesn't exist */
         stringObjPtr = Jim_NewEmptyStringObj(interp);
-        freeobj = 1;
     }
     else if (Jim_IsShared(stringObjPtr)) {
-        freeobj = 1;
         stringObjPtr = Jim_DuplicateObj(interp, stringObjPtr);
     }
 
@@ -455,10 +452,7 @@ static int Jim_PackCmd(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
     }
 
     if (Jim_SetVariable(interp, argv[1], stringObjPtr) != JIM_OK) {
-        if (freeobj) {
-            Jim_FreeNewObj(interp, stringObjPtr);
-            return JIM_ERR;
-        }
+        return JIM_ERR;
     }
     return JIM_OK;
 }