diff options
| author | Steve Bennett <steveb@workware.net.au> | 2025-07-07 22:56:36 +1000 |
|---|---|---|
| committer | Steve Bennett <steveb@workware.net.au> | 2025-07-07 23:03:06 +1000 |
| commit | 5b72bde554529818ca288d54deac63dd2e428483 (patch) | |
| tree | 7af7ff60cf3a3f1ba2b23f8adf5a1e9a72afcbc5 /jim-history.c | |
| parent | 6c1d558d1df64683184c305250917490940a0062 (diff) | |
| download | jimtcl-master-next.zip jimtcl-master-next.tar.gz jimtcl-master-next.tar.bz2 | |
core: Jim_SetVariable() now frees value on errormaster-next
If the value has a zero reference count, free it in the error path.
Otherwise callers can't do: Jim_SetVariable(..., Jim_New...())
in case the object is leaked in the error path.
Fix various callers that were previously freeing the object in the
error path, and add a test to loop.test to show that this was not.
Signed-off-by: Steve Bennett <steveb@workware.net.au>
Diffstat (limited to 'jim-history.c')
| -rw-r--r-- | jim-history.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/jim-history.c b/jim-history.c index c43bdca..39ddf5d 100644 --- a/jim-history.c +++ b/jim-history.c @@ -24,7 +24,6 @@ static int history_cmd_getline(Jim_Interp *interp, int argc, Jim_Obj *const *arg /* Returns the length of the string if varName was specified */ if (argc == 2) { if (Jim_SetVariable(interp, argv[1], objPtr) != JIM_OK) { - Jim_FreeNewObj(interp, objPtr); return JIM_ERR; } Jim_SetResultInt(interp, Jim_Length(objPtr)); |