jim.c: Simplify Jim_GetIndex() for int conversion

This approach avoids a coverity warning

Signed-off-by: Steve Bennett <steveb@workware.net.au>

1 files changed, 7 insertions, 4 deletions

diff --git a/jim.c b/jim.c
index 21502d5..22444e8 100644
--- a/jim.c
+++ b/jim.c
@@ -7393,10 +7393,13 @@ int Jim_GetIndex(Jim_Interp *interp, Jim_Obj *objPtr, int *indexPtr)
     if (objPtr->typePtr == &intObjType) {
         jim_wide val = JimWideValue(objPtr);
 
-        if (!(val < LONG_MIN) && !(val > LONG_MAX)) {
-            *indexPtr = (val < 0) ? -INT_MAX : (long)val;;
-            return JIM_OK;
-        }
+        if (val < 0)
+            *indexPtr = -INT_MAX;
+        else if (val > INT_MAX)
+            *indexPtr = INT_MAX;
+        else
+            *indexPtr = (int)val;
+        return JIM_OK;
     }
     if (objPtr->typePtr != &indexObjType && SetIndexFromAny(interp, objPtr) == JIM_ERR)
         return JIM_ERR;