diff options
| author | Noah Moroze <noahmoroze@gmail.com> | 2024-05-15 22:49:23 -0400 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2024-06-08 08:44:04 +0000 |
| commit | 7050cade9dcea77dd9882669ea97fddc6a8084d4 (patch) | |
| tree | 266c6cfb730e2ab2fd8a8e13f21669210bbd466e /tcl/chip | |
| parent | 223e3d8fe76d86f01111bbe37f83a19d719ac81a (diff) | |
| download | riscv-openocd-7050cade9dcea77dd9882669ea97fddc6a8084d4.zip riscv-openocd-7050cade9dcea77dd9882669ea97fddc6a8084d4.tar.gz riscv-openocd-7050cade9dcea77dd9882669ea97fddc6a8084d4.tar.bz2 | |
tcl/chip/st/spear: fix syntax errors
While the current jimtcl does not consider this an error, the Tcl
dodekalogue states that strings terminate at the second double quote
character (see https://www.tcl.tk/man/tcl/TclCmd/Tcl.htm#M8).
These syntax errors were caught by tclint v0.2.5
(https://github.com/nmoroze/tclint):
```
tclint tcl/chip/st/spear/spear3xx_ddr.tcl | grep "syntax error"
```
Change-Id: I2763d93095e3db7590644652f16b7b24939d6cae
Signed-off-by: Noah Moroze <noahmoroze@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8281
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Diffstat (limited to 'tcl/chip')
| -rw-r--r-- | tcl/chip/st/spear/spear3xx_ddr.tcl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tcl/chip/st/spear/spear3xx_ddr.tcl b/tcl/chip/st/spear/spear3xx_ddr.tcl index 5992567..0696221 100644 --- a/tcl/chip/st/spear/spear3xx_ddr.tcl +++ b/tcl/chip/st/spear/spear3xx_ddr.tcl @@ -10,7 +10,7 @@ proc sp3xx_ddr_init {ddr_type {ddr_chips 1}} { if { $ddr_chips != 1 && $ddr_chips != 2 } { - error "Only 1 or 2 DDR chips permitted. Wrong value "$ddr_chips + error "Only 1 or 2 DDR chips permitted. Wrong value $ddr_chips" } if { $ddr_type == "mt47h64m16_3_333_cl5_async" } { @@ -21,7 +21,7 @@ proc sp3xx_ddr_init {ddr_type {ddr_chips 1}} { # ????? $ddr_chips # set ddr_size 0x????? } else { - error "sp3xx_ddr_init: unrecognized DDR type "$ddr_type + error "sp3xx_ddr_init: unrecognized DDR type $ddr_type" } # MPMC START |