aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAntonio Borneo <borneo.antonio@gmail.com>2025-03-29 22:51:59 +0100
committerAntonio Borneo <borneo.antonio@gmail.com>2025-04-05 06:22:43 +0000
commit04124c77f48b9748b88b4ccf77a36665855ee73e (patch)
tree2aa0d6e50e58097649c8a4ecd1c0db213ecbee4f /src
parent169d463a3d3c91f62c980aba287b5e110b310ad0 (diff)
downloadriscv-openocd-04124c77f48b9748b88b4ccf77a36665855ee73e.zip
riscv-openocd-04124c77f48b9748b88b4ccf77a36665855ee73e.tar.gz
riscv-openocd-04124c77f48b9748b88b4ccf77a36665855ee73e.tar.bz2
target: fix memory leak in handle_target_write_memory()
Commit f55ec6d44922 ("target: rewrite command 'write_memory' as COMMAND_HANDLER") adds a new return statement without freeing the allocated buffer. Add the needed free(). Fixes: f55ec6d44922 ("target: rewrite command 'write_memory' as COMMAND_HANDLER") Change-Id: I676d658118b32f4d7cc71eda3436bb52f1966cd8 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8822 Tested-by: jenkins
Diffstat (limited to 'src')
-rw-r--r--src/target/target.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/target/target.c b/src/target/target.c
index 7baeedd..3b62e0d 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4608,6 +4608,7 @@ COMMAND_HANDLER(handle_target_write_memory)
int jimretval = Jim_GetWide(CMD_CTX->interp, tmp, &element_wide);
if (jimretval != JIM_OK) {
command_print(CMD, "invalid value \"%s\"", Jim_GetString(tmp, NULL));
+ free(buffer);
return ERROR_COMMAND_ARGUMENT_INVALID;
}